yep, I get these error msgs when I go to "Create album":

* warning: Invalid argument supplied for foreach() in /home/trancepl/public_html/modules/node/node.module on line 504.
* warning: implode() [function.implode]: Bad arguments. in /home/trancepl/public_html/modules/node/node.module on line 508.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /home/trancepl/public_html/includes/database.mysql.inc on line 172.

Comments

vhmauery’s picture

vhmauery commented
Status: Active » Fixed

Okay. This one is fixed. I made some changes to the way acidfree_types is handled and evidently it created quite a few regressions. I should have tested it more. But a little late for that. Now all I can do is hope I can find and fix them before everyone else does.

Fixed in CVS.

kalashari’s picture

kalashari commented

I actually fixed it before you commited to CVS.

althought I edited node.module, and just before that line 504 I added:

if(!isset($param))return;

Now, the only error msg I get is:

warning: Missing argument 3 for acidfree_link() in /home/trancepl/public_html/modules/acidfree/acidfree.module on line 810.

and it is appearing on pages that are not connected to Acidfree.

vhmauery’s picture

vhmauery commented
Status: Fixed » Closed (fixed)

The point is that Acidfree was misbehaving, not a node.module bug. You shouldn't have to modify Drupal to run Acidfree.

yodersj’s picture

yodersj commented
Priority: Critical » Normal
Status: Closed (fixed) » Active

I'm still getting those same three errors after updating to the latest 5.x-1.x-dev created on May 20th. This is a fresh install, done on May 18th, of Drupal 5.1. Originally had installed the 5.x-1.x-dev created on May 19th and saw those errors then. Didn't have time until tonight to check into it and saw your update. Installed the update and ran update.php. Don't know if it matters, but just in case ...
Core-opt modules enabled are: Comment, Contact, Help, Menu, Path, Taxonomy
Additional modules enabled are: Content 5.x-1.5, Image 5.x-1.1, Image-Attach 5.x-1.1, Acidfree 5.x-1.x-dev, Slideshow Creator 5.x-1.21, Slideshow Creator CCK 5.x-1.21, TinyMCE 5.x-1.x-dev, Video 5.x-1.x-dev, Views 5.x-1.6-beta5, Views-UI 5.x-1.6-beta5
Acidfree site-wide settings are: (all at default at this time)

I have created one album even with the errors and, as far as I can tell with this being my first time using Acidfree, it appears to function okay. If I should start from scratch again and then install your latest, just let me know. At this point I can because it is just a test site. Thank you.

sunfish62’s picture

sunfish62 commented

I didn't see this one when I submitted http://drupal.org/node/145569 --sorry.

I just downloaded from here, and still have the problem--is there some special place where this latest version is?

vhmauery’s picture

vhmauery commented
Status: Active » Fixed

Okay. I had fixed it for the case of node/add/acidfree/nnn but not for node/add/acidfree. This is really fixed now. Change committed to CVS.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)