If you have an URL with "-" character and the download type is "git", the function which parses the URL is not expecting "-" in the host.
I think this should be added because there are loads of hostnames with "-" characters.

CommentFileSizeAuthor
#1 drush_make-hyphens_in_hostnames-1454470-1.patch592 bytesbrenv

Comments

brenv’s picture

brenv commented
Version: 6.x-2.3 » 6.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new drush_make-hyphens_in_hostnames-1454470-1.patch592 bytes

I think the hyphen should indeed be included for a hostname (http://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names)

I attach a patch which I think fixes this. Apologies if there is any problem with it, this is my first ever submission of a patch to Drupal!

bren

helmo’s picture

helmo commented
Status: Needs review » Closed (won't fix)

Closing this issue as I doubt anyone will ever commit again to the obsolete drush_make project. See checkout a recent drush version, see also: #1310130: Put drush make in drush core