When an invalid extension is provided to the video_upload module, an infinite loop occurs because when viewing the newly created node page, the code keeps redirecting to the same node page over and over (infinite redirection) until it times out. This has been solved by commenting out the redirection code when an invalid extension node is viewed.
The video module also rejected upper-case extensions (like .MOV) and considered them invalid (again, causing an infinite loop), this has been fixed by wrapping the return type of _video_get_filetype in strtolower so now .MOV is considered valid.
This patch removes the redirection code that results in an infinite loop on invalid extensions and allows upper case valid extensions to be uploaded as well. It's a simple two liner patch.
| Comment | File | Size | Author |
|---|---|---|---|
| video_6.patch | 549 bytes | Ashraf Amayreh |
Comments
Comment #1
mlncn commentedVerifying that this patch is good, for the version 5 of the time: I provided the same fix (hadn't found this at the time). However, in Drupal jeopardy I lose, having not framed my answer in the form of a patch ;-)
Comment #2
fax8 commentedcommitted. thanks.
Comment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.