"Changes made in this list will not be saved until the form is submitted. " is briefly appearing in AJAX mode.
I'm actually seeing 2 of them.

Only occurring on the first sort. After that they don't return unless you reload the page and sort again (first time).

CommentFileSizeAuthor
#8 draggableviews-1455664-message-ajax.patch2.06 KBygerasimov
#5 draggableviews-1455664-5.patch901 bytesyarroha

Comments

MickL’s picture

MickL commented

I'm getting two of this messages, too! I'm not using the ajax mode but an html list in drupal 7.12

MickL’s picture

MickL commented
Title: Form submit message in Ajax mode » Two Form submit messages
keesee’s picture

keesee commented
Title: Two Form submit messages » Form submit message in Ajax mode

benchi, thanks for verifying this.

renaming the title back it back to what it was. Having the message display twice one of the problems... but the bigger problem is that the UI is telling the user their changes won't be saved in AJAX mode. AJAX mode saves in real time. Hence the message shouldn't show up at all... or a different message needs to be displayed telling them changes have been saved.

"Changes made in this list will not be saved until the form is submitted."
In AJAX mode there not a submit button. This will almost certainly confuse the user.

MickL’s picture

MickL commented

So we got two problems here:

1.) The message is displayed twice
2.) Message is displayed even though ajax mode

yarroha’s picture

yarroha commented
Assigned: Unassigned » yarroha
Status: Active » Needs review
StatusFileSize
new draggableviews-1455664-5.patch901 bytes

I added some additional checking. Now message is not displayed twice and is not displayed in the ajax mode.

MickL’s picture

MickL commented

is this patch in the latest dev ?

yarroha’s picture

yarroha commented

no, I did it for the last git version.

ygerasimov’s picture

ygerasimov commented
StatusFileSize
new draggableviews-1455664-message-ajax.patch2.06 KB

Here is patch that fixes:
1. Two messages appear on list.
2. Message doesn't show on second, third sort.
3. If view is ajaxified message "Order of the list has been changed." is shown for 3 seconds and faded out.

Is it good enough?

ygerasimov’s picture

ygerasimov commented
Status: Needs review » Fixed

Comitted.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.