Related to: #1457346: Upgrade path: 6.x-1.x to 6.x-2.x.

Port the ctools plugin support that was built into 6.x-2.x to 7.x-2.x.

Comments

Bastlynn’s picture

Bastlynn commented
Status: Active » Needs review

A port for 7.x-2.x is up at http://drupalcode.org/project/webform_ab.git/shortlog/refs/heads/7.x-2.x for peer review. If you can take a look and let me know if I have anything off in this?

BrockBoland’s picture

BrockBoland commented

Looks good! I haven't touched this module in ages so I'm not well-equipped to test it all now, but I reviewed the diff and it looks great. I appreciate all the cleanup you did, with things like using drupal_substr() and check_plain() where I'd failed to and things like that.

The only concern I have is the removal of the webform_ab_win_thresholds and webform_ab_win_conditions tables. Those may have already been deprecated (honestly, I can't even remember), but I just wanted to double-check that those were accounted for one way or another.

Also: as far as I'm concerned, you're the primary maintainer on this one, so feel free to release whatever you want whenever you're ready! :-)

Bastlynn’s picture

Bastlynn commented

Hm, I'm still seeing them in the install file actually - so not sure if there was another location you were looking at? I'll get this tested over the next week. :)

BrockBoland’s picture

BrockBoland commented

Indeed it is! I just did a git diff 6.x-2.x and reviewed the output: for some reason, that diff is showing those tables removed from the schema, but they are indeed still in the install file. Weird.

Looks good to me then!

Bastlynn’s picture

Bastlynn commented
Assigned: Unassigned » Bastlynn
Status: Needs review » Fixed

I got in and did some heavy testing of this, ready to release it as an alpha. So closing this :)

Bastlynn’s picture

Bastlynn commented
Status: Fixed » Closed (fixed)