Closed (fixed)
Project:
Droogle
Version:
6.x-1.0-beta3
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Feb 2012 at 21:50 UTC
Updated:
29 Mar 2012 at 02:00 UTC
I am testing Droogle using the site-wide configuration rather than for individual groups.
User permissions are configured so that only one role can access Droogle.
I am surprised to find that anonymous visitors can also view the Droogle page by simply going to the path http://example.com/droogle
Comments
Comment #1
barnettech commentedI just pushed a fix to this to the 6.x-1.x branch When I see it gets pushed to the downloads page I'll close this.
Comment #2
barnettech commentedJust pushed the same fix to the 7.x branch as well.
Comment #3
barnettech commentedjust checked the fix is now available on the downloads page or via drush
Comment #4
izmeez commentedI have just tested 6.x-1.0-beta1 and it is not solving the problem for me.
Can someone else confirm if this is an issue for them or not?
The user permissions I have available are:
administer droogle
administer google apps
use google apps
I don't see a permission for view google docs.
I am not sure if there is some other module conflict going on and if I will have to test the Droogle module on a fresh install. Hopefully not.
Thanks.
Comment #5
barnettech commentedI verified the code base says "view google docs" http://drupalcode.org/project/Droogle.git/blob/refs/heads/6.x-1.x:/droog...
perhaps you have a different google module installed. I have never used that verbiage in any version of my code. you need to run drush update on Droogle and
then clear your cache.
Comment #6
izmeez commentedThis may still need work.
I discovered what my error was, human error :-) I had two directories, droogle and Droogle because of what I had been doing.
Anyway, after clearing that out and installing 6.x-1.0-beta2 when I enable the module I get the following error and a WSOD:
I am not sure if this is related to the fix or if I should open a separate issue for this.
Thanks.
Comment #7
barnettech commentedthis is interesting. Basically the reviewers of the module suggested I use the code on line 10. But it only works on higher versions of PHP. http://php.net/manual/en/function.constant.php So it is not a bug, but it does mean that folks on lower versions of PHP will have a problem. I do plan on fixing this to not be as tied to a higher version of PHP.
Comment #8
barnettech commentedOk I pushed out 6.x-1.0-beta3 which no longer uses the const language to make a constant, I changed it to use a simple variable instead so folks on lower versions of php can use the module. The Drupal 7 version still has the old way since presumably it is an upgrade in Drupal version, and I will assume their php version as well.
Comment #9
izmeez commentedI have tested 6.x-1.0-beta3 and still no cigar.
I no longer get the WSOD and the module still behaves as before. (beta1)
That is the Droogle page can be accessed by anonymous users.
Under permissions I am now only seeing two permissions:
administer droogle
upload google docs
The navigation menu item is also now too long as it is the full "DROOGLE: A list of your google docs".
I have disabled, uninstalled, re-enabled, cleared caches; all to no avail.
When I removed beta1 I do not recall seeing the uninstall and wonder if there are some tables or entries left from the original install that need to be removed.
Comment #10
barnettech commentedMy apologies, I had put the 'view google docs' access control in the Drupal 7 branch but omitted it from the Drupal 6 branch. I just put the code in and pushed it. Let me know if there any problems.
Comment #11
barnettech commentedforgot to switch it to fixed.