Calling hook_init() should be avoided as it makes it impossible to reliable use the aggressive caching method of Drupal 5. As the hook is only used for setting some define()s to enable debugging, I would just set the defines outside the function.

BTW: I don't think the module should include debugging code. This may be useful for a -dev branch, but not for releases.

CommentFileSizeAuthor
path_image.init_.patch1.24 KBRobrecht Jacques

Comments

AjK’s picture

AjK commented

Robrecht,

I have added you as a CVS co-maintainer to the project. Feel free to commit (tested) patches :)

Thanks for your input and feedback.

cheers,
--Andy

Robrecht Jacques’s picture

Robrecht Jacques commented

I've started commiting my (small) patches. Will test the $_SERVER['DOCUMENT_ROOT'] a bit more this afternoon before committing it.

About this issue: are you ok with removing the debugging stuff? Or do you prefer it to stay?

Robrecht Jacques’s picture

Robrecht Jacques commented
Status: Needs review » Fixed

Fixed in 5.x-1.x-dev.

I did not remove the debugging information.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)