When using the Pathauto module, it's only possible to replace punctuation with the default seperator. With this module, an extra option is added so that a user can provide his own seperator for each punctuation option.

Project

http://drupal.org/sandbox/robinvdvleuten/1458724

Git Repository

git.drupal.org:sandbox/robinvdvleuten/1458724.git

Drupal Version

7.x

Comments

kongoji’s picture

kongoji commented
Status: Needs review » Needs work

Hi robinvdvleuten,
welcome with your module!

Here something I noticed doing a manual review:
1) you should not insert the module version in .info file. When your module will became a full project, you'll add module version using git tags (read http://drupal.org/node/711070#release-tag) and Drupal system will add version to .info file for you
2) at line 20, 67 and 68 there is the word "seperator", I guess is a mispelled "separator".
3) you should create a .install file to delete all variables pathauto_punctuation_*_custom when the module is uninstalled.

You have also some code style to correct, see automatic validation here:
http://ventral.org/pareview/httpgitdrupalorgsandboxrobinvdvleuten1458724git

Cool module!

robinvdvleuten’s picture

robinvdvleuten commented
robinvdvleuten’s picture

robinvdvleuten commented
Status: Needs work » Needs review

Hi kongoji,

Thanks for reviewing my module! I've included the changes from your manual review and corrected the code styling.
I totally forgot the .install file, glad you've mentioned it! Hopefully it's all correct now :)

patrickd’s picture

patrickd commented

Hi,
we need more reviewers as there are currently many applications in queue
so think about getting a review bonus and we will come back to your application sooner.

sam152’s picture

sam152 commented
Status: Needs review » Reviewed & tested by the community

From the testing I did, I found this module to work exactly as described. The UI is great and seems to be in the logical place.

I have not gained commit status yet, as my module is personally still under review, but I think this project deserves "reviewed and tested" status.

Good luck from here on out, and keep up the good work.

patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Fixed

Sorry for the delay!

Please take a moment to make your project page follow tips for a great project page.

I'm afraid this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, I have promoted this single project manually to a full project.
Sorry, I hope you can understand this. Please consider to come back later with a *little* more complex module.

The project Pathreplace has been promoted to a full project.
New URL: http://drupal.org/project/pathreplace

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.
git remote set-url origin patrickd@git.drupal.org:project/pathreplace.git

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.