iTunes Feed Formatters

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./rss_itunes_subtitle.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function rss_itunes_subtitle_field_formatter_info() {
  function rss_itunes_subtitle_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  

• ./rss_itunes_keywords.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function rss_itunes_keywords_field_formatter_info() {
  function rss_itunes_keywords_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  

• ./rss_itunes_explicit.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function rss_itunes_explicit_field_formatter_info() {
  function rss_itunes_explicit_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  

• ./rss_itunes_summary.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function rss_itunes_summary_field_formatter_info() {
  function rss_itunes_summary_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  

• ./rss_itunes_author.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function rss_itunes_author_field_formatter_info() {
  function rss_itunes_author_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./rss_itunes_explicit.info:   ASCII text, with CRLF line terminators
  ./rss_itunes_image.info:      ASCII text, with CRLF line terminators
  ./rss_itunes_author.info:     ASCII text, with CRLF line terminators
  ./rss_itunes_subtitle.info:   ASCII text, with CRLF line terminators
  ./rss_itunes_summary.info:    ASCII text, with CRLF line terminators
  ./rss_itunes_keywords.info:   ASCII text, with CRLF line terminators
  rss_itunes_author.info
  rss_itunes_author.module
  rss_itunes_explicit.info
  rss_itunes_explicit.module
  rss_itunes_image.info
  rss_itunes_image.module
  rss_itunes_keywords.info
  rss_itunes_keywords.module
  rss_itunes_subtitle.info
  rss_itunes_subtitle.module
  rss_itunes_summary.info
  rss_itunes_summary.module
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

welcome,

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools, as pointed out above.
At least moving to a version specific branch should be done before switching back to "needs review".

You can also get a review bonus and we will come back to your application sooner.

regards

You add a little more explaining to your project-page:

• What happens after enabling your modules?
• which tokens/infos are used for which feed-tag?
• How to decide which feed-tag is needed?
• Maybe a link to http://www.apple.com/itunes/podcasts/specs.html

Are there dependencies between the different modules?
Why is every feed-tag a single module, wouldn't it be cleaner to combine them in a single or core-module and extentions?

Micha

@Ryan thank you for your efforts.

The way creating feeds by the template-system may be more customizable for the pros, but imho the beginner (as I) would prefere the views_rss_tunes way.
By the way, they have created a nice documentation, what would be a lot of work for a module like yours.

Micha

Hi, RyanParsley. This is a very nice contribution. Thanks for submitting it for review as your first full project!

Here are the issues I found with your code:
* Your project is named itunes_feed_formatters, yet your module namespace is rss_itunes_*
* You're using separate modules for each field formatter. These can all be merged into a single module, and preferably module-name_views.inc
* Your project name doesn't use the views_ namespace.
* An view export based on your code would be tremendously helpful for review. (Also a similar one of the other module for comparison wouldn't hurt.)

Views RSS iTunes hasn't fully taken off yet, so I recommend you either continue working on this code or help improve that project. Do either of those options appeal to you? How would you like to move forward?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.