Getting this for every single file download on HEAD. Not getting it on 5.x-1.0-rc3:

Destination directory /tmp/make_tmp_1330394607_4f4c35ef90779/__build__/profiles/tv411_install/libraries/[FOLDER] already exists.

Here's an example:

libraries[jsDraw2D][download][type] = "get"
libraries[jsDraw2D][download][url] = "http://jsdraw2d.jsfiction.com/jsDraw2D.js"

libraries[jquery.cycle][download][type] = "get"
libraries[jquery.cycle][download][url] = "https://github.com/downloads/malsup/cycle/jquery.cycle.all.2.88.min.js"

libraries[jquery.ui.touch-punch][download][type] = "get"
libraries[jquery.ui.touch-punch][download][url] = "https://raw.github.com/furf/jquery-ui-touch-punch/766dcf98e4c9bd371edfd4bd113d21a34033e6a6/jquery.ui.touch-punch.min.js"

Gives this result:

jsDraw2D downloaded from http://jsdraw2d.jsfiction.com/jsDraw2D.js. [ok]
Destination directory /tmp/make_tmp_1330394607_4f4c35ef90779/__build__/profiles/tv411_install/libraries/jsDraw2D already exists. [error]
jquery.cycle downloaded from https://github.com/downloads/malsup/cycle/jquery.cycle.all.2.88.min.js. [ok]
Destination directory /tmp/make_tmp_1330394607_4f4c35ef90779/__build__/profiles/tv411_install/libraries/jquery.cycle already exists. [error]
jquery.ui.touch-punch downloaded from https://raw.github.com/furf/jquery-ui-touch-punch/766dcf98e4c9bd371edfd4bd113d21a34033e6a6/jquery.ui.touch-punch.min.js. [ok]
Destination directory /tmp/make_tmp_1330394607_4f4c35ef90779/__build__/profiles/tv411_install/libraries/jquery.ui.touch-punch already exists. [error]
CommentFileSizeAuthor
#8 drush-1459624-08.patch1.13 KBjhedstrom
#7 drush-1459624-07.patch1.14 KBjhedstrom

Comments

adamdicarlo’s picture

adamdicarlo commented
Priority: Normal » Critical
Issue tags: +Release blocker

Assuming this regression is a critical release blocker, so tagging.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Isn't this a duplicate of #1459624: Single file download with make is broken with directory exists errors?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

And by that I mean #1143936: Downloading a single file breaks if the folder doesn't exist, but that appears to have already been resolved.

imiksu’s picture

imiksu
Location Finland
commented

I can confirm this. I'm using cufon library:

libraries[cufon][download][type] = "get"
libraries[cufon][download][url] = "http://cufon.shoqolate.com/js/cufon-yui.js"
libraries[cufon][directory_name] = "cufon"
libraries[cufon][destination] = "libraries"

This error comes after committing "In make, use drush copy/move/delete wrappers instead of cp/mv/rm".

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue tags: +Needs tests
dude4linux’s picture

dude4linux commented

I can confirm I'm seeing similar errors. They seem to affect the downloading of third-party libraries and not drupal.org projects.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs work
StatusFileSize
new drush-1459624-07.patch1.14 KB

Here's a test that integrates the example from #4 into file.make. No solution to the breakage yet though.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new drush-1459624-08.patch1.13 KB

Changed the test to use jquery.cycle from the initial post, since that is versioned and won't change.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Fixed

I added the cufon example form #4 to the get test and verified that it failed. Then I reverted one line from http://drupalcode.org/project/drush.git/commit/d16701f in order to get test to pass. We could perhaps do more here but this is good enough for the moment.

Automatically closed -- issue fixed for 2 weeks with no activity.