After deleting a domain with theme settings, rows still exist under 'domain_theme' which should be removed. Patch is attached.

CommentFileSizeAuthor
#8 1459742-domain-theme-delete-d6.patch585 bytesagentrickard
#7 1459742-domain-theme-delete-d72.patch3.13 KBagentrickard
#2 05_domain_theme-7.x-3.x-settings-cleanup-2.patch566 bytesRory
domain_theme-7.x-3.x-settings-cleanup.patch571 bytesRory

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Category: support » bug
Status: Needs review » Needs work

First param shouldn't need a default value. Otherwise looks good.

Rory’s picture

Rory commented
Status: Needs work » Needs review
StatusFileSize
new 05_domain_theme-7.x-3.x-settings-cleanup-2.patch566 bytes

Removed default value from first parameter. Thanks for the review.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community

This is fine, though I will replace the extreme indenting in the final version.

Rory’s picture

Rory commented

OK, thanks. By appropriate standards should such indenting be just two spaces in?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Yes. Though some folks like your format, core would indent those 2 spaces.

It's minor. I'll clean it up.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Patch (to be ported)

While checking the API for this patch, I found we were still using d6 queries in our examples. So I fixed that, too.

Oddly, this was never implemented in < 7.x.3 either.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 1459742-domain-theme-delete-d72.patch3.13 KB

Pushed to 7.x.2

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Patch (to be ported) » Fixed
StatusFileSize
new 1459742-domain-theme-delete-d6.patch585 bytes

And for d6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.