$itemClass and $listClass would suggest that they are class names, and not objects, but you definitely store objects in those, maybe renaming them simply to $item and $list would be more accurate.

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Category: bug » task
Status: Active » Postponed
Issue tags: +Migrate 3

I'm not going to change this now, if anyone's derived from MigrateSourceList it will break. We'll rename these with the next API version.

pounard’s picture

pounard
Primary language French
commented

Fair enough, please keep that in mind for next majors.

pifagor’s picture

pifagor commented
Issue summary: View changes
Status: Postponed » Closed (outdated)