Error message when i add a node

subscribe

This is an issue with the nid not existing in form_state on submit.

Patch attached.

I had same issue. Use hook_node_insert and hook_node_presave. Here is the code which works for me
/*
* insert new record for a node in node_class table
*/
function node_class_node_insert($node){
db_insert('node_class')->fields(array('nid' => $node->nid, 'css_class' => $node->node_class['css_class']))->execute();

}
/*
* Update node class
*/
function node_class_node_presave($node){
db_update('node_class')
->fields(array(
'css_class' => $node->node_class['css_class']
))
->condition('nid',$node->nid)
->execute();
}

Note: Please remove form_submit function (line 67 to 88).

I didn't want to completely rewrite the author's module, but you'll see the attached patch uses hook_node_insert. Once s/he commits these patches, I'd be happy to remove _submit.

I'm still getting the error in #1 after the patch on #2 is applied. The patch was successful but the error remains.

Edit: Once editing pre-existing content there is no error message, but upon creating new content it's output.

can #4 not be implemented asap? It does say minimally maintained on the status. I'm sure some help to fix this would be appreciated rather than it being viewed as a takeover process.

This little mod will be very handy indeed once errors are fixed. :)

Not sure how I missed this earlier, but sure enough - a clean checkout & patch from #2 and the error still appears. I'm attaching a patch with changes from #2 and the fix for the error.

Great the error has gone, thanks drnikki.

Patch applied & committed.

http://drupalcode.org/project/node_class.git/commit/88ceb91

Hy!
The error is back in version 7.x-1.1: After install this module and i add a new content, i become this error message:

Notice: Undefined property: stdClass::$nid in node_class_attributes() (Zeile 31 von /var/www/mywebsite.com/sites/all/modules/node_class/node_class.module).

I use Drupal 7.17 and the node class module 7.x-1.1

I test the git version and 7-x.1.1 in a new local environment an both versions works as design...
I don't know what was the problem before...

I got the same problem!

Please find a solution... my Drupal version is 7.22

I find out a simple solution to this...

Goto: node_class.module :
// Add submit handler for node_class module
Remove: $form['#submit'][] = 'node_class_form_submit';
Add : $form['actions']['submit']['#submit'][] = 'node_class_form_submit';

@shivani.shah or Maintainers
Can you writhe a patch pleace?
Then we can test it by the community (RTBC)

Patch for Node Class Module:
line 29:
function node_class_attributes($node) {
+ if(isset($node->nid))
+ {
$ret = db_query('SELECT css_class FROM {node_class} WHERE nid = :nid',
array(':nid' => $node->nid))->fetchField();
return $ret ? $ret : '';
+ }
+ else
+ {
+ return '';
+ }
}

The code in #18 works fine!

@Maintainers: Pleace create a patch an commited to dev. Thanks!

Thanks for suggestion in #18. Can someone who knows how to commit this?

Find attached an actual patch.

I have also got error -
Notice: Undefined property: stdClass::$nid in node_class_attributes() (line 31 of D:\xampp\htdocs\ultracorporatepixel.com\sites\all\modules\node_class\node_class.module).

I delete the below lines from 29 to 33 in node_class.module file -

function node_class_attributes($node) {
  $ret = db_query('SELECT css_class FROM {node_class} WHERE nid = :nid', 
    array(':nid' => $node->nid))->fetchField();
  return $ret ? $ret : '';
}

And add the below lines in that place from line 29

function node_class_attributes($node) {
 if(isset($node->nid))
 {
$ret = db_query('SELECT css_class FROM {node_class} WHERE nid = :nid',
array(':nid' => $node->nid))->fetchField();
return $ret ? $ret : '';
 }
 else
 {
 return '';
 }
}

And this works. Thanks nomorerice.

hi
with the drupal 7.24 it still gives the same error
with the comment #23 done the error disappeared
thanks

That looks fixed with 7.x-1.3

Yup, confirming that this is fixed in 1.3:

function node_class_attributes($node) {
  // dev note:
  // Get css attribute information ONLY if node already existed.
  // if we're here the $form[#node] object will have already been
  // created but it won't have an nid because it hasn't been saved
  if (!isset($node->nid)) {
    return "";
  }

  return db_query('SELECT css_class FROM {node_class} WHERE nid = :nid', array(':nid' => $node->nid))->fetchField();
}

Fixed in commit:

commit 88ceb91fa9ce28198ebf6f932d2bdc9df5ac2678
Author: Nikki Stevens
Date: Thu May 3 10:29:44 2012 -0400

Issue #1558112 #4160056 by drnikki: node save & edit errors

In which case, this issue should be closed.