When clicking a hierarchy facet, I do want to include the parent AND the child even if the facet is configured as an OR

Hi jarchowk.

Thanks for the post. Judging by what you are saying this isn't Facet API's responsibility and should probably be posted against the backend module you are using. Facet API is responsible for displaying the results, whereas the backend is responsible indexing the results, querying the results, and determining the facet counts which is where this issue is being introduced.

From a Solr standpoint, the module work by indexing all terms associated with the hierarchy. So for example, take the following hierarchy:

Fruit: 1
  - Apple: 2
  - Orange: 3
Veggies: 4
  - ...

If you had a document tagged with "Apple", that document would index values 1 and 2. If you had a document tagged with "Orange", it would index values 1 and 3. Therefore by what you are trying to do, the application is working exactly as designed. You are effectively adding an "OR Fruit" clause when the parent is selected, so it will match all documents with a tid of "1". I am not sure what the right approach is to solving this issue, as the way the module indexes content would probably have to change. I am wondering whether the techniques at http://wiki.apache.org/solr/HierarchicalFaceting would help. Either way, that change has to happen outside of Facet API.

Thanks,
Chris

Sorry for closing this again, but I would really start with the backend since Facet API does not handle the indexing, count calculation, or filtering of the results. If you can point to a specific line of code in Facet API that is causing this bug then I will be happy to work with you, otherwise all of the symptoms outlined above are outside of Facet API's responsibility and handled by the individual backends implementing the API.

Let me un-close this. I think that a "needs more info" is probably a friendlier and more applicable status.

OK, I think I see where you are going with this, and thanks for the clarification. Give me a little bit to think through the use cases and implications.

Thanks,
Chris

I think based on the comments in #6 this is valid, but I am not sure where the best place to add this is. Trying to code up a patch so we can start working on this with a base of functionality to start hacking from.

I'm working on a project and i've got the same issue.
Here a quick patch (1.x-dev / 1.0-rc4) to fix this (it's worked for me), but i'm pretty sure this is not the best way to fix this.
I did'nt find another place to fix this than in the contrib module "search_api_facetapi" of "search_api".

Based on #9, I am thinking this is a feature request against Search API? If there is some way to make this agnostic to the backend I am willing to add it to Facet API, but seeing how the feature is added to Search API is makes more sense to punt it over to the Search API issue queue.

Node status

I'd like to add some context here for this problem that got solved in Apache Solr & Facet API

https://drupal.org/project/apachesolr_exclude_parent_terms

Seeing that we're moving soon with D8 I'm bumping it up and it should certainly get a backport if that seems possible

Makes sense. I'm open for D7 patches too, though, as long as we haven't started with facets in D8 anyways.

I think this makes more sense in D7 right now. In D8, we should of course strive to get this right the first time.

Also, in my eyes, that's a bug, not a feature request. Having hierarchical OR facets work the way they do now isn't really useful to anyone, I'd say.

[sorry I logged with the wrong user account] original user: @sebas5384

The last patch worked as expected!!
Rerolled and added a condition to avoid the hierarchy overload when is a flatten widget.

[this message were to be with this user]

This patch seems unnecessary in the last version of search api.

This patch seems unnecessary in the last version of search api.

So now it's already working correctly for you?
Then maybe it was fixed in Facet API, because I don't think I've changed anything in that area.

Also, if a patch is still needed, it should take into account hierarchies in general, not only taxonomy terms. And, more importantly, you should be aware that the term query type applies to all fields except dates by default, it doesn't have anything to do with taxonomy terms (and, thus, is not just for them).

The issue I just added changed how this behaves (and a few commits after made additional tweaks). It seems to do the opposite of what was requested in that it's now impossible to show a taxonomy as a hierarchy, but have them treated as individual terms. (Parent terms are removed, so OR queries including both a child and its parent are now broken.)

Forgot to change the state...

Btw, the patches above also seem to do the opposite of what the OP requested. I also want to make OR queries including parent and child, as some nodes are tagged with the parent, some with the child, some with both.
This works if I flatten the hierarchy, but then there's no point in having the hierarchy as terms can't be displayed as having a relationship...

Thinking about it, this should have worked as desired before any of the mentioned patches were applied...

Can you give a real-world use case/example for this behavior? You're correct in that I don't think we currently support it, or even thought about it, but I also can't really imagine where this might really be handy.

Anyone else who wants this behavior? Then I guess we could make it configurable.

I'm looking for the following behavior (I think this is the right issue for it, apologies if it isn't):

- I have a taxonomy based facet for a vocabulary called 'Sewing pattern types', that has a 1 level hierarchy:

- Clothes
-- Dress
-- Shirt
-- Pants
- Curtains
-- Long curtains
-- Short curtains
etc

- When I select one of the parent terms, I would like the search to return results tagged with the child terms as well as the parent term. This currently doesn't happen: only results tagged with the parent term are returned.
- When I drill down further in the hierarchy, I'd like the parent term facet to become inactive. This currently works for me in the current version (if I understand correctly, that was the focus of #2450227: Ignore parent terms in facets when operator is OR).

Using Apache Solr. My facet operator is set to OR; 'Treat parent items as individual facet items' is set to 'No' (nothing changes when I set it to 'Yes').

I'm looking for the following behavior (I think this is the right issue for it, apologies if it isn't):

No, it isn't, and it seems like you just need to add the "Index hierarchy" processor to the index.

I think we can safely say this is outdated.