Closed (fixed)
Project:
Ubercart
Version:
7.x-3.x-dev
Component:
Other
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Feb 2012 at 15:13 UTC
Updated:
5 May 2012 at 19:10 UTC
Please, consider adding the following single line to uc_attribute.module, line 1289, inside function _uc_attribute_alter_form():
$attr_type = ''; // <<<<<<
switch ($attribute->display) {
...
}Apart from being good PHP practice to initialize variables in such cases, it also allows other modules to add new attribute types, without giving a warning later in line 1303 where this variables is used.
Comments
Comment #1
longwaveComment #2
longwaveFixed in both branches.
Comment #3
djg_tram commentedThanks.
Comment #4.0
(not verified) commentedMissing comma