views-exposed-filters.tpl.php in Commons roots makes all views exposed filters collapsed by default. Easy enough to override in a custom theme using a views-exposed-filters.tpl.php (for all those having a similar issue) but it'd be interesting to find out why this is the default behavior in Commons and if there is any functionality that depends on it.

Personally I like the idea of Views exposed filters being in a fieldset (for accessibility reasons) but implementing this in the template as opposed to a form alter hook makes it a bit harder to modify and override (eg collapse some exposed forms and not others) in modules and features.

Comments

ezra-g’s picture

ezra-g commented
Priority: Minor » Normal

This should absolutely be in a form_alter and not in a template. Bumping to normal priority since this can cause head-scratching and poor DX.

jsibley’s picture

jsibley commented

I'll agree about the head-scratching.

So, if it is moved out of the template to a form_later, does that mean it will be configurable (I assume so, but haven't gotten that deep into Drupal innards)?

codesidekick’s picture

codesidekick commented

If it's moved from the template into the form array then you could easily do a hook_form_alter in a custom module and change whether it's opened, closed, renders as a fieldset or just a div, change its fieldset label etc per form. You can see what properties fieldsets support by going to http://api.drupal.org/api/drupal/developer%21topics%21forms_api_referenc... and looking at the fieldset column in the first table.

jsibley’s picture

jsibley commented

Any progress on this, by any chance?

DaveLindberg’s picture

DaveLindberg commented

subscribe

ezra-g’s picture

ezra-g commented

@DaveLindberg, Please use the "follow" button at the top of the screen instead of posting a new comment.

jsibley’s picture

jsibley commented

@ezra-g, do you know if there has been any progress on fixing this? Thanks.

ezra-g’s picture

ezra-g commented

@jsibley, Any progress on this issue will be reflected here. Patches are definitely welcome.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Is this still an issue in D7?