potential namespace issues
jgraham - May 22, 2007 - 18:57
| Project: | Content Type Administration by Organic Group |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | rconstantine |
| Status: | closed |
Jump to:
Description
Some functions are named '*_og_content_type*' rather than '*_og_content_type_admin*' this could cause potential namespace issues with og_content_type.
See attached diff for proposed fix.
| Attachment | Size |
|---|---|
| og_content_type_admin.module.diff | 1.94 KB |
#1
Good point. I'll make the change.
Is there some other module using og_content_type? I'm not aware of it.
#2
#3
No not that I'm aware of, but one of those things its good to stay on good practice in the event somebody did want to do so in the future.
Thanks for the prompt turnaround and nice module BTW.
#4
Thanks. Look for several other OG modules in the coming weeks including OG-specific cck fields. This should be cool. If you've ever wanted to add just one more field to a content type for a specific group without duplicating that type, now you'll be able to. I'm creating a module in the vein of taxonomy_fields, but for OGs. The first time I read the description for taxonomy_fields I was like, huh? The second read through I had this idea. The tricky part will be view access I think. We'll see. I haven't decided on the best implementation yet.
Right now I've got several cck modules in the works.
Anyway, I hear you have a patch in the works which addresses an access issue I failed to consider, namely creating content by directly entering a url. It seems I missed a case that you've identified. I look forward to seeing that.
#5
"Anyway, I hear you have a patch in the works which addresses an access issue I failed to consider, namely creating content by directly entering a url. It seems I missed a case that you've identified. I look forward to seeing that."
Yeah I was a little slow to create it. This is from the downloaded dev version dated 20070524
http://drupal.org/node/147781
#6