This is both because you use module_invoke (instead of module_invoke_all) and because your various _engine database columns aren't normalized. This prevents me from, say, archiving feed items in the database (via simplefeed_item.module) but also emailing them (via simplefeed_mail.module) or any other particular module that listens to the hook. Ultimately, each feed node should have a checkboxes of all known save engines which the admin can check on and off. This particular bug is a blocker for me - I had intentions of creating simplefeed_item_not_nodes.module and simplefeed_mail.module and releasing them, but not I have to make simplefeed_crapshoot.module instead and keep it to myself.

Comments

csevb10’s picture

csevb10 commented

I decided to use module_invoke instead of module_invoke_all for performance, but I can see your point. I'll see about modifying the arrangement of the save both at the db & php level and see about incorporating that back in.

m3avrck’s picture

m3avrck commented

Patches are welcome :-)

And nothing stops you from writing a module that implements an engine that does multiple things either.

boris mann’s picture

boris mann commented

/me just wants everyone to get along....

Seriously, I think that Morbus has some big ideas and long time history in this area. Having him as a force for good with SF would be....a good thing. Darth Morbus, on the other hand...

Maybe we can schedule some time for a chat so we can all kiss and makeup and make SF kick ass?

m3avrck’s picture

m3avrck commented
Status: Active » Closed (works as designed)

http://drupal.org/project/feedapi

Use FeedAPI if you need more flexibility :-)