Since this module doesn't fire any code unless the User Pictures option is enabled at admin/user/settings, and since this option is disabled by default, it might be nice to either:
a) Warn the user if this option is disabled, note that it is required, and point them to the user settings page to turn it on.
b) Automatically enable it when the module is initially installed.

Here's a patch that does b). I removed the watchdog message when the module is installed since that's not something I'd seen other modules do, so it looked like debugging code. If not, feel free to add it back. :)

CommentFileSizeAuthor
user_pictures_install.patch1.12 KBwebchick

Comments

stella’s picture

Assigned: Unassigned » stella
Status: Needs review » Fixed

I've made these changes and added them to CVS. However, I went with (a) instead. I also added a warning about the 'user pictures' option being disabled to the avatar selection settings forms.

Cheers,
Stella

Anonymous’s picture

Status: Fixed » Closed (fixed)
stella’s picture

Released in avatar_selection-5.x-2.0.

Cheers,
Stella