Clarify comment and use gender-neutral language in contextual.test [#1462062]

Problem/Motivation

The following comment added #1425280: No contextual links in node lists after a node without contextual links in is a little confusing and contains unecessarily gendered language

+++ b/modules/contextual/contextual.testundefined
@@ -0,0 +1,47 @@
+    // Promote nodes to the front page. One article node the user can edit, one
+    // page node he can not edit and another article node he can edit.

Proposed resolution

Reword the comment to be a little clearer and refer to "the user" instead of "he" in all cases. Making "The user" the subject of the sentence should help clear it up a bit, as might a list of the three nodes.

Comment	File	Size	Author
#4	Gendered-language-1462062-3.patch	1.01 KB	chertzog
#1	Gendered-language-1462062-1.patch	963 bytes	chertzog

Comments

Comment #1

chertzog

he/him

English

Harrisburg, PA, USA

commented 5 March 2012 at 22:11

Status:

Active

» Needs review

Status	File	Size
new	Gendered-language-1462062-1.patch	963 bytes

I think this patch should clarify the comment.

**** YAY! My first patch for Core! +1 for the Novice tag! ******

Comment #2

xjm

she/her

English

commented 5 March 2012 at 22:40

Yay! Thanks @chertzog. The patch follows all our coding standards, and I think the comment is a lot more clear now.

I talked to NiklasFiekas, who worked on the original patch a bit, and he said the order of the nodes is important in this case, which I didn't realize at first. So to clarify that, maybe we could do something like:

// Create three nodes in the following order:
// - An article, which should be user-editable.
// - A page, which should not be user-editable.
// - A second article, which should also be user-editable.

Would that work? (Also note the hyphen in "user-editable.")