New module for core - replies

This doesn't actually look ready for HEAD (hook_menu is 5.x, e.g.) ?

+1 for this functionality in Drupal 6 though (even if simple as a first pass - the inclusion of a hook is a good start).

Fun, but I don not need this module. It should be an additional modules.

-1

@moshe - i just quickly skimmed the code for replies.module. after looking at replies_getrecipients(), i'm confused. you still have to add a comment to subscribe to a thread, which is what i thought this whole thing was supposed to avoid. or is that proposed for round 2? eventually, you'll add your own table for this module, to track "silent subscriptions", sort of like project_issue.module does for the customized email issue subscription stuff, but more fine-grained? ideally, the silent subscriptions would also showup in the tracker, if there was a way to do that which didn't kill performance of the tracker again.

sorry, duh, re-reading comment #3: i plan to enhance this module so that one can subscribe to a node without posting a comment.. ;) hehe, in that case, could you elaborate a little? would that be targetted for D6 core, too, or not? if not, would it be possible to extend replies.module with a hook so that contribs could implement their own notion of who subscribed to a node via whatever means they want?

speaking of feature creep, once we have a separate table for the subscriptions so you don't need to comment, it'd be nice if there was a way to unsubscribe from a node that you commented on (where unsubscribe means no email, no activity in your tracker, etc). that's outside the scope of the original patch, but i'd like to hear about if/how you'd plan to support that in the future.

re: issue followups as comments, see http://drupal.org/node/18920.

anyway, i don't want to complicate this particular issue with too many feature requests, but i've certainly thought about this problem a lot and would like to see the big picture plan for where this functionality is going, even if the initial patch is relatively small and simple, which lays the basis for further work.

thanks,
-derek

this doesn't have a patch

didn't read the post:

"Please see the contrib module named 'replies' for the patch."

good point...

This module is needed on many sites. Having it in core is a good idea.

Some comments:

- There does not seem to be a way for users to turn of email replies. So if the site admin turns this module on, there is no way to stop the spam from coming.

- Why call the hook "replies_mine", as opposed to just "replies"?

- The emails are sent in real time. If there are big threads with many participants, or many comments being posted to different threads, this could increase the server load. Not a concern on small sites, but better point to this in the help and README.

- Another approach (overkill for a simple module in core, but perhaps a contrib that uses the replies hook can do that), is to batch the emails with a threshold and have cron send them once an hour or day ...etc.

+1 for core nonetheless.

Sounds like this is an appropriate status.

Didn't see this issue when I posted http://drupal.org/node/322064.

Was there ever an issue to move token to core? I couldn't find one.

dfer:
Indeed there is: See #113614: Add centralized token/placeholder substitution to core. I really hope it's getting included, because so many contrib modules depend on Token.

Token is in core now, so this is no longer postponed. It is D8, though, because it is a new feature.

There's been a lot more discussion in #322064: Add comment notifications via e-mail so I'm going to mark this as a duplicate of that issue (sorry). Blame the system, not the messenger. :)