Issue with the current module:

  • Not scalable as you're dependent on Select/Checkboxes
  • No Negate
  • Not flexible for future development

To solve these issues I have created a new version basically which is based on the path context (Actually extends that class now). Now you can simply add the domains you wish to trigger context on in a textfield. And similar to the path condition you can now use the tilde symbol "~" in-front of the domain to exclude it. This makes this module way more flexible and scalable.

I am not a pro at creating patches so the match might have to be redone. Please let me know if you have any questions. Would be nice to see this module implement this feature as I think it's incredibly handy.

Any feedback or questions are welcome.

CommentFileSizeAuthor
#2 domaincontext-context_condition_domain-1462950-1.patch3.55 KBgrndlvl
domaincontext_context_condition_domain.patch3.74 KBjnpwebdeveloper

Comments

grndlvl’s picture

grndlvl commented

Re-rolled patch so that it will apply.

When creating patches please see http://drupal.org/node/707484.

Also I have created a different approach to solving the solution for exclusive/inclusive logic @ #1480604: Include/Exclude selected sites for context..

grndlvl’s picture

grndlvl commented
StatusFileSize
new domaincontext-context_condition_domain-1462950-1.patch3.55 KB

Meant to attach re-roll.

xjm’s picture

xjm
she/her
Primary language English
commented

Thanks for the patch! Since Domain Context does not have a test suite, I'd like to have some folks test this on their existing sites and confirm the results.

bforchhammer’s picture

bforchhammer commented
Status: Needs review » Needs work

This still needs work... if I read the patch correctly, it replaces the domain list with a textarea for hostnames ("subdomain" values), and then tries to match those against the current domain.

I think that the textarea should work with domain ids (or even better: machine names) instead of hostnames, and let the domain access module do the domain matching... That's been tested a already, and also allows to automatically match domain aliases.

Edit: Hm, I just saw that #1480604: Include/Exclude selected sites for context. solves the mentioned problem; Maybe this issue can be closed then?

jnpwebdeveloper’s picture

jnpwebdeveloper commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)