Github Flavored Markdown

welcome,

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(This has to be fixed before you can switch back to "needs review")

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxjohnnybgoode1462208git

You can also get a review bonus and we will come back to your application sooner.

Hi, You have created the branch "6.x-1.0". This git branches do not match the release branch pattern, you should remove/rename them. this module is for drupal 6 or drupal 7?

After you moved your files from master to branch, remove all the files from master branch.

Thanks

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/gfm.module
--------------------------------------------------------------------------------
FOUND 185 ERROR(S) AFFECTING 84 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
11 | ERROR | Spaces must be used to indent lines; tabs are not allowed
11 | ERROR | Line indented incorrectly; expected 4 spaces, found 2
11 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
11 | ERROR | Comments may not appear after statements.
12 | ERROR | Spaces must be used to indent lines; tabs are not allowed
12 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | Line indented incorrectly; expected 4 spaces, found 2
21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
32 | ERROR | There should be no white space after an opening "("
32 | ERROR | There should be no white space before a closing ")"
33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
33 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
33 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
34 | ERROR | Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | Line indented incorrectly; expected 4 spaces, found 2
34 | ERROR | There should be no white space after an opening "("
34 | ERROR | Concat operator must be surrounded by spaces
34 | ERROR | There should be no white space before a closing ")"
35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
35 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
38 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
39 | ERROR | Line indented incorrectly; expected 4 spaces, found 2
39 | ERROR | There should be no white space after an opening "("
39 | ERROR | Concat operator must be surrounded by spaces
39 | ERROR | There should be no white space before a closing ")"
40 | ERROR | Spaces must be used to indent lines; tabs are not allowed
40 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
41 | ERROR | Spaces must be used to indent lines; tabs are not allowed
43 | ERROR | Spaces must be used to indent lines; tabs are not allowed
43 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
43 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
44 | ERROR | Spaces must be used to indent lines; tabs are not allowed
44 | ERROR | Line indented incorrectly; expected 4 spaces, found 2
44 | ERROR | There should be no white space after an opening "("
44 | ERROR | Concat operator must be surrounded by spaces
44 | ERROR | There should be no white space before a closing ")"
45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
45 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
46 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
49 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
50 | ERROR | Spaces must be used to indent lines; tabs are not allowed
50 | ERROR | Line indented incorrectly; expected 4 spaces, found 2
50 | ERROR | There should be no white space after an opening "("
50 | ERROR | Concat operator must be surrounded by spaces
50 | ERROR | There should be no white space before a closing ")"
51 | ERROR | Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | Line indented incorrectly; expected at least 6 spaces, found 3
52 | ERROR | Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
60 | ERROR | You must use "/**" style comments for a function comment
61 | ERROR | Spaces must be used to indent lines; tabs are not allowed
61 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
61 | ERROR | There should be no white space after an opening "("
61 | ERROR | There should be no white space before a closing ")"
62 | ERROR | Spaces must be used to indent lines; tabs are not allowed
62 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
63 | ERROR | Spaces must be used to indent lines; tabs are not allowed
64 | ERROR | Spaces must be used to indent lines; tabs are not allowed
64 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
65 | ERROR | Spaces must be used to indent lines; tabs are not allowed
65 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
66 | ERROR | Spaces must be used to indent lines; tabs are not allowed
72 | ERROR | You must use "/**" style comments for a function comment
73 | ERROR | Spaces must be used to indent lines; tabs are not allowed
73 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
79 | ERROR | You must use "/**" style comments for a function comment
80 | ERROR | Spaces must be used to indent lines; tabs are not allowed
80 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
81 | ERROR | Spaces must be used to indent lines; tabs are not allowed
81 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
82 | ERROR | Spaces must be used to indent lines; tabs are not allowed
82 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
82 | ERROR | There should be no white space after an opening "("
82 | ERROR | There should be no white space before a closing ")"
83 | ERROR | Spaces must be used to indent lines; tabs are not allowed
83 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
84 | ERROR | Spaces must be used to indent lines; tabs are not allowed
85 | ERROR | Spaces must be used to indent lines; tabs are not allowed
85 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
91 | ERROR | You must use "/**" style comments for a function comment
92 | ERROR | Spaces must be used to indent lines; tabs are not allowed
92 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
101 | ERROR | Spaces must be used to indent lines; tabs are not allowed
107 | ERROR | You must use "/**" style comments for a function comment
108 | ERROR | Spaces must be used to indent lines; tabs are not allowed
108 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
109 | ERROR | Spaces must be used to indent lines; tabs are not allowed
109 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
109 | ERROR | No space found after comma in function call
109 | ERROR | Concat operator must be surrounded by spaces
110 | ERROR | Spaces must be used to indent lines; tabs are not allowed
110 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
116 | ERROR | You must use "/**" style comments for a function comment
117 | ERROR | Spaces must be used to indent lines; tabs are not allowed
117 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
117 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
118 | ERROR | Spaces must be used to indent lines; tabs are not allowed
118 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
140 | ERROR | Spaces must be used to indent lines; tabs are not allowed
146 | ERROR | You must use "/**" style comments for a function comment
147 | ERROR | Spaces must be used to indent lines; tabs are not allowed
147 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
148 | ERROR | Spaces must be used to indent lines; tabs are not allowed
148 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
149 | ERROR | Spaces must be used to indent lines; tabs are not allowed
149 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
156 | ERROR | Spaces must be used to indent lines; tabs are not allowed
156 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
157 | ERROR | Spaces must be used to indent lines; tabs are not allowed
157 | ERROR | Array indentation error, expected 3 spaces but found 2
158 | ERROR | Spaces must be used to indent lines; tabs are not allowed
158 | ERROR | Array indentation error, expected 4 spaces but found 3
159 | ERROR | Spaces must be used to indent lines; tabs are not allowed
159 | ERROR | Array indentation error, expected 4 spaces but found 3
161 | ERROR | Spaces must be used to indent lines; tabs are not allowed
161 | ERROR | Array indentation error, expected 4 spaces but found 3
161 | ERROR | Concat operator must be surrounded by spaces
162 | ERROR | Spaces must be used to indent lines; tabs are not allowed
162 | ERROR | Array indentation error, expected 5 spaces but found 4
163 | ERROR | Spaces must be used to indent lines; tabs are not allowed
163 | ERROR | Array indentation error, expected 5 spaces but found 4
164 | ERROR | Spaces must be used to indent lines; tabs are not allowed
164 | ERROR | Array indentation error, expected 5 spaces but found 4
164 | ERROR | Concat operator must be surrounded by spaces
165 | ERROR | Spaces must be used to indent lines; tabs are not allowed
165 | ERROR | Array indentation error, expected 4 spaces but found 3
166 | ERROR | Spaces must be used to indent lines; tabs are not allowed
166 | ERROR | Array indentation error, expected 4 spaces but found 3
166 | ERROR | Concat operator must be surrounded by spaces
167 | ERROR | Spaces must be used to indent lines; tabs are not allowed
167 | ERROR | Array indentation error, expected 5 spaces but found 4
168 | ERROR | Spaces must be used to indent lines; tabs are not allowed
168 | ERROR | Array indentation error, expected 5 spaces but found 4
169 | ERROR | Spaces must be used to indent lines; tabs are not allowed
169 | ERROR | Array indentation error, expected 5 spaces but found 4
169 | ERROR | Concat operator must be surrounded by spaces
170 | ERROR | Spaces must be used to indent lines; tabs are not allowed
170 | ERROR | Array indentation error, expected 4 spaces but found 3
171 | ERROR | Spaces must be used to indent lines; tabs are not allowed
171 | ERROR | Array indentation error, expected 4 spaces but found 3
171 | ERROR | Concat operator must be surrounded by spaces
172 | ERROR | Spaces must be used to indent lines; tabs are not allowed
172 | ERROR | Array indentation error, expected 5 spaces but found 4
173 | ERROR | Spaces must be used to indent lines; tabs are not allowed
173 | ERROR | Array indentation error, expected 5 spaces but found 4
174 | ERROR | Spaces must be used to indent lines; tabs are not allowed
174 | ERROR | Array indentation error, expected 5 spaces but found 4
174 | ERROR | Concat operator must be surrounded by spaces
175 | ERROR | Spaces must be used to indent lines; tabs are not allowed
175 | ERROR | Array indentation error, expected 4 spaces but found 3
176 | ERROR | Spaces must be used to indent lines; tabs are not allowed
176 | ERROR | Array indentation error, expected 4 spaces but found 3
176 | ERROR | Concat operator must be surrounded by spaces
177 | ERROR | Spaces must be used to indent lines; tabs are not allowed
177 | ERROR | Array indentation error, expected 5 spaces but found 4
178 | ERROR | Spaces must be used to indent lines; tabs are not allowed
178 | ERROR | Array indentation error, expected 5 spaces but found 4
179 | ERROR | Spaces must be used to indent lines; tabs are not allowed
179 | ERROR | Array indentation error, expected 5 spaces but found 4
179 | ERROR | Concat operator must be surrounded by spaces
180 | ERROR | Spaces must be used to indent lines; tabs are not allowed
180 | ERROR | Array indentation error, expected 4 spaces but found 3
181 | ERROR | Spaces must be used to indent lines; tabs are not allowed
181 | ERROR | Array indentation error, expected 3 spaces but found 2
182 | ERROR | Whitespace found at end of line
182 | ERROR | Spaces must be used to indent lines; tabs are not allowed
183 | ERROR | Spaces must be used to indent lines; tabs are not allowed
183 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
--------------------------------------------------------------------------------

@ themeprofessional
Please don't paste these automated reports into an issue, it makes the issue look clumby and can be quite demotivating for the applicant
you should rather attach it as file or provide a direct link to its online version.

please edit your previous comment and remove this, thanks

Hi, I'm very sorry for the delay, there are currently hundreds of applications and only a handful of reviewers :(
We really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

Nice cleanup!! Looks like the only thing left in ventral - is to clean up 2 of ur function names to be prefixed by your module name

http://ventral.org/pareview/httpgitdrupalorgsandboxjohnnybgoode1462208git

I was trying to follow the readme for 7.x-1.x and have a few comments

• Is it possible to rename the module so that the folder name / project name matches the actual module name? I'm not sure if this is an actual coding standards issue, but it's a bit of pain trying to drush en -y github_flavored_markdown and then realizing that you should've enabled gfm
• Got a set of notices right after I enabled gfm and markdown modules and tried to add a filter. screenshot attached(1)
• When I followed the install instructions, checked all the boxes under github flavored markdown settings, and put gfm before markdown filter, I got another set of warnings - screenshot attached(2)
• Went to go make a node using gfm, and while it worked great (good job btw ;) ), I still got a set of warnings - screenshot attached(3)

This was on a clean d7 install with only devel enabled.

I'll set this to needs work. Let me know if you need further help replicating the problems :)

Is it possible to rename the module so that the folder name / project name matches the actual module name? I'm not sure if this is an actual coding standards issue, but it's a bit of pain trying to drush en -y github_flavored_markdown and then realizing that you should've enabled gfm

Current git project name depends on full project name on d.o, this can only be changed by setting the shortname when promoting the project

Ah good to know for the future :)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

edit project information