sparkline and libraries integration

nice catch-- thanks for posting. I'll have a commit for cleaning up the libraries integration today.

The only thing you need to do to make sparklines work is enable them in the 'details page options' fieldset at admin/config/media/download-count.

are you still having problems with them?

http://drupalcode.org/project/download_count.git/commit/793e286

closed for no response.

I'm having the same problem with sparklines not working. I've verified that sites/all/libraries/jquery.sparkline/jquery.sparkline.min.js is in place. I've attached screenshots of my Download Count settings page, the main report page, and the Download Count Details – All Files page where I'm seeing 0 Total Downloads and no sparklines. (So really, the problem goes beyond just the sparklines not showing up!)

Let me know if there's any info I can provide to help figure out what's up there. I'm using the most recent 7.x-3.x-dev and Drupal 7.12.

Ah! Notice that the Details - All Files report says "Current as of Tuesday, February 7, 2012 - 2:15pm with 0 items still queued to cache." That seems significant! I'd installed Download Count temporarily on Feb 7 but then uninstalled it again until today.

Thanks for the screenshots-- that's quite helpful.

Not sure it's a sparkline problem though since with 0 downloads you won't have a sparkline.

Can you check to make sure cron is running and completing successfully?

Also, are there any download_count messages in the watchdog report?

And finally, take a look at the db and let me know if there's anything in the download_count_cache table.

Unfortunately I started taking shots in the dark to try to resolve this, so my troubleshooting wasn't very methodical. After noticing the February 7, 2012 message, I disabled, uninstalled, and re-enabled download_count via Drush. After that, no download_count activity occurred – no stats logged in any reports no matter how many times I tested downloads, no watchdog activity for download_count other than my attempts to disable and enable the module to get things working again. Both the download_count and the download_count_cache tables in the db are empty.

I then reloaded an earlier database dump from before I disabled and uninstalled download_count today, and download_count started working again; private downloads are being logged, download_count messages are appearing as expected in watchdog. The download_count table in the database now has rows corresponding to each download, but download_count_cache table is still empty. The Detail report is still showing 0 and the message "Current as of Tuesday, February 7, 2012 - 2:15pm with 0 items still queued to cache," so this put me back to where I was before.

Now that I know that the detail reports depend on cron running, I've checked that it's running and completely successfully, and I've run cron manually. After running cron, I had results in my Detail reports! But still no sparklines.

I then went back to the Download Count settings page and changed the Sparklines settings from "Line" (which I believe was the default, since I didn't change that setting before) to "Bar." Reloaded the Detail report, and boom, there are bars! Switching back to the "Line" setting for Sparklines results in no sparklines again, but I think that's because I've only got 2 downloads in the system, both from today, and a line graph needs more data than that to display anything, right?

All that is to say: it appears that sparklines integration is working properly; however, there does seem to be a problem with uninstalling and reinstalling download_count and getting absolutely no download_count activity afterward. I was able to reproduce that problem in my local environment just now.

Also, what's the expected behavior of the "x items still queued to cache" message on the details report? Even if cron hasn't run again and there are recorded downloads that are not yet appearing in the details report, that message always still says "0 items still queued to cache."

Sorry to go completely off topic here; I hope this is still helpful, and I'd be happy to create new issues for these other problems if necessary!

wow -- that has to be the best issue comment ever, lol. It gives me lots to work with. I'm outta time for today, but I'm gonna try to replicate your findings on a new install to see if i can figure out what's going on. For now lets just keep it here, and I can open more issues if I can reproduce the events. I'll post back when I have some more info.

Thanks again!

I've installed, uninstalled, and reinstalled dc many many times and never did manage to replicate this. Feel free to reopen if you if you still have problems.

I'm having the same problem (tried it with sparklines 2.1.2 -- newest and 1.6). Not sure if it will help, but Chrome is letting me know that "Uncaught Type Error: Object [object Object] has no method 'sparkline'".

I really wish I could track this down, but try as I might, I just can't reproduce this. I just tested again with both firefox and chrome and v1.6 of jquery sparkline works fine.

I just installed this module on my dev site, and this issue is the only problem I've encountered so far. The Download Counts page looks fine, but when I click on the Details of a file that definitely has more than zero downloads, the Download Count Details page claims that the file has a total of zero downloads. A corresponding log is made.

Type: page not found
Location: https://www.mysite/jquery.sparkline.min.js?v=1.6
Referrer: https://www.mysite/admin/reports/download-count/1/details?render=overlay
Message: jquery.sparkline.min.js

I find it interesting that the Location query string specifies v=1.6. I assume this refers to a jquery version.

Under admin->Configuration->jQuery update, I have my Default jQuery version set to 1.10. The options for jQuery versions I have don't even include 1.6. Rather, I have:
Default (provided by Drupal)
1.5
1.7
1.8
1.9
1.10