I am testing out the expired password functionality and when I come back to change the password it does not allow me to get into the edit form to do so. Doing this as admin 1 user.

The only way to get in is to manually delete the module. Any advice is greatly appreciated.

CommentFileSizeAuthor
#6 password_policy-password_tab_not_available-1463568-6.patch1.35 KBjim kirkpatrick
#4 password_policy-password_tab_not_available-1463568-4.patch1.74 KBjim kirkpatrick

Comments

erikwebb’s picture

erikwebb commented

Can you explain what policies you have set? Did you recently register or force a password change?

jbsc’s picture

jbsc commented

I had basic policies set for length and capital and 1 number.

I had not recently registered. I executed the expired password command to test it but then it just took me to the user page with the message to reset password but it would not let me hit the edit tab. I also noticed that it had repeated that form 2x on the page.

In troubleshooting I turned off the password tab module and now it seems to work properly. I will do some more testing.

jim kirkpatrick’s picture

jim kirkpatrick commented

Confirmed: the tab link for "example.com/user/[uid]/password" just shows the user's profile page. Like #2, user 1 can access these pages, but a normal user cannot... I therefore think this is a permission or hook_menu issue and am looking into it.

jim kirkpatrick’s picture

jim kirkpatrick commented
Category: support » bug
Status: Active » Needs review
StatusFileSize
new password_policy-password_tab_not_available-1463568-4.patch1.74 KB

OK, think I've fixed it... There were 2 issues:

  1. The password_policy_password_tab_menu() that made the password tab wasn't right for the 'user/[uid]/password' address as laid out elsewhere in the module.
  2. The callback function password_policy_password_tab() for the above menu entry had the wrong parameters.

The attached patch fixes these and issues outlined in #2 and makes the password tab work as expected.

Status: Needs review » Needs work

The last submitted patch, password_policy-password_tab_not_available-1463568-4.patch, failed testing.

jim kirkpatrick’s picture

jim kirkpatrick commented
StatusFileSize
new password_policy-password_tab_not_available-1463568-6.patch1.35 KB

Let's try that patch again in the right directory...

jim kirkpatrick’s picture

jim kirkpatrick commented
Status: Needs work » Needs review
erikwebb’s picture

erikwebb commented
Status: Needs review » Needs work

This will likely be changed (or fixed) given the patch in issue #1330502: Update password change tab to Drupal 7. Can you apply that patch first? I will likely commit it first, in the next few days.

erikwebb’s picture

erikwebb commented
Status: Needs work » Fixed

I'm comfortable getting this patch in before the full Password Change Tab module upgrade is done.

http://drupalcode.org/project/password_policy.git/commit/236ace5

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.