Hello,

first of all: thanks for your module and thanks for your effort! The module looks very good, however, it does have an issue with drupal installations that aren't installed in "/" but in "/".

The code in line 92 in pdfpreview.module is:

$output = '<img src="/' . $output_filename . '" title="' . $item['data']['description'] . '" alt="' . $item['data']['description'] .'" />';

but it should be

$output = '<img src="' . base_path() . $output_filename . '" title="' . $item['data']['description'] . '" alt="' . $item['data']['description'] .'" />';

If there is anyone who needs a patch I'll provide one, just let me know here.

Comments

KhaledBlah’s picture

KhaledBlah commented

just noticed there is a similar problem in line 101:

<$tag class=\"image-wrapper\"><a href=\"/{$item['filepath']}\" title=\"{$item['data']['description']}\">

should be

<$tag class=\"image-wrapper\"><a href=\"" . base_path() . "{$item['filepath']}\" title=\"{$item['data']['description']}\">
KhaledBlah’s picture

KhaledBlah commented

is there any comment from the developer at all?

juanjo_vlc’s picture

juanjo_vlc commented
Assigned: Unassigned » juanjo_vlc

I've put your proposed fix on the 6.x-1.x release.

Thanks.

juanjo_vlc’s picture

juanjo_vlc commented
Status: Active » Fixed
juanjo_vlc’s picture

juanjo_vlc commented
Status: Fixed » Closed (fixed)