Let use fields to build RSS items

Triggering the testbot.

As you asked in irc, you could use the tokens of views, so you could use arguments automatically.

+    static $row_index;
+    if (!isset($row_index)) {
+      $row_index = 0;
+    }
+

You can just use $view->row_index;

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,165 @@
+      if (isset($element['namespace'])) {
+        $this->view->style_plugin->namespaces = array_merge($this->view->style_plugin->namespaces, $element['namespace']);

You could use the same code like in views_plugin_row_node_rss::render(). There is some additional code for rdf namespaces.

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,165 @@
+    if (empty($this->view->style_plugin) || !is_object($this->view->style_plugin) || empty($field_id)) {
+      return '';

Are these checks really required? I'm wondering whether you could just use $this->view->style_plugin->get_field directly.

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,174 @@
+ * Plugin which render an RSS item based on fields.

"Use a 3rd person verb to begin the description of a class", also "render" should be "renders".

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,174 @@
+    $options['guid_field_options']['guid_field_is_permalink'] = array('default' => TRUE);

Needs 'bool' => TRUE as well

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,174 @@
+      '#description' => t('The field that is going to be used as the RSS item pubDate for each row. It need to be in RFC 2822 format.'),

"It need to be" should be "It needs to be"

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,174 @@
+      '#description' => t('The Globally unique identifier of the RSS item.'),

Globally should be lowercase

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,174 @@
+    $item = new stdClass();
+    $item->title = $this->get_field($row_index, $this->options['title_field']);

This section could use some inline docs.

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,174 @@
+      'attributes' => array('isPermaLink' => $guid_is_permalink_string)

Missing trailing comma

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,174 @@
+   * Convinience method  to retrieve field output.

Double space, and the comment should start differently, like the docs say: "beginning with a verb in the form "Does such and such" (third person, as in "This function does such and such", rather than second person imperative "Do such and such")."

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,175 @@
+    $options['guid_field_options']['guid_field'] = array('default' => 'none', 'bool' => TRUE);
+    $options['guid_field_options']['guid_field_is_permalink'] = array('default' => TRUE);

Er, the bool is now on the wrong line. Sorry! I think this is good otherwise.

Okay now I just feel like a jerk, but I thought of a couple more things.

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,175 @@
+    $options['title_field'] = array('default' => 'none');
+    $options['link_field'] = array('default' => 'none');
+    $options['description_field'] = array('default' => 'none');
+    $options['creator_field'] = array('default' => 'none');
+    $options['date_field'] = array('default' => 'none');
+    $options['guid_field_options']['guid_field'] = array('default' => 'none');

See below about replacing 'none' with '';

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,175 @@
+    foreach ($this->display->handler->get_handlers('field') as $field => $handler) {
+      $view_fields[$field] = $handler->ui_name();

Could this be replaced by $this->display->handler->get_field_labels();?

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,175 @@
+      if (empty($this->options[$required_option]) || $this->options[$required_option] == 'none') {

If 'none' was replaced with '' as the empty default, these conditionals could be much simpler

+++ b/plugins/views_plugin_row_rss_fields.incundefined
@@ -0,0 +1,175 @@
+    if (empty($this->options['guid_field_options']['guid_field']) || $this->options['guid_field_options']['guid_field'] == 'none') {

.

Okay, rerolled with a couple tweaks we discussed on IRC, I rolled it with credit for @marvil07 so this should be good to use with `git am`.

Thanks for all the work! I did a final review and committed it to 7.x-3.x