Key-value pairs as one variable [#1466154]

This is the module to allow you save many variables (key-value style)and persist them in one record of the variable table in the backend database to prevent the records bloat of variable table and get storage efficiency. Also, you get a better UI to do the insert/update/delete operation in batch.

After you set the variable, you can get it by using kvpairsinone_get($key)

Comments

Comment #1

patrickd commented 3 March 2012 at 12:51

Status:

Needs work

» Needs review

welcome,

I'm not sure how much sense your module makes by the fact that it is generally no problem to store whole arrays into one variable
like
variable_set(array('key' => 'value', 'key2' => 'value2', ...))

Are you sure there is really a need for this? please explain why

Anyway:
You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(At least this has to be done before switching back to needs review)

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxwilby1465886git

Please take a moment to make your project page follow tips for a great project page.

The readme file must be named: "README.txt"

You can also get a review bonus and we will come back to your application sooner.

regards

Comment #2

patrickd commented 3 March 2012 at 12:51

Status:

Needs review

» Needs work

Comment #3

yang.wilby commented 4 March 2012 at 02:30

Status:

Needs review

» Needs work

Thank you for you reviewing work!

I agree with that there is no problem to store whole arrays into one variable, What this module does is to supply a UI and usage to do the insert/update/delete operations on the whole arrays in batch and conveniently.

Also, I have fix the code style and move from the master to a version branch.

Comment #4

chhavik commented 18 March 2012 at 16:12

Manual review :-

Improve comments for all the function calls. Refer comment formatting conventions
Use proper commenting for hooks. For eg: Implements hook_menu().
Line 81, 85: Don't wrap case condition in t()
Line 145: Pass a proper access parameter.