Support wymeditor 0.5-a1

Here is a report of the 'work in progress':

On the WYMeditor's side, some bugs had to be fixed (see WYMeditor's Trac)

On Drupal's side, WYM 0.3 module currently requires JQuery Update module, a patch for 'collapse-fix.js' and JQuery 1.1.3a.

The good news are that it does work with Drupal 5 and that WYMeditor no longer needs to be uploaded to the Drupal's CVS.

My short term goals are :
- propose the 'collapse-fix.js' patch to JQuery Update's issue queue.
- create the CVS branch for WYM 0.3

Any questions or comments are welcome ;-)

My feelings now:
If there is an easy way to run JQuery 1.1.3a with Drupal 5 (namely, if jquery_update can be made compatible with JQuery 1.1.3a by backporting the 6.x core patches), I will create the 5.x branch for WYMeditor 0.3.
If not, WYMeditor 0.3 will be a Drupal 6.x project.

What do you think of this ?

I say go for d6.
Maybe it would be much trouble converting the module from the d5 to the d6 fapi and get the corefixes that you talk about backported.

Hi no new is not always good news, did Moxide answer you on this? D6 is prob. not out before oct/nov and then all modules have to be tested, so it quickly takes 1/2 year before it is usable (I think). Do you know what version of jQuery D6 is running?

--
Steinmb

Well, just got the email and 0.4 stable is out. I'd love to see it go in :).

That is great news! Ver. 0.4 now work much better with Opera :) I was waiting for that to be solved. I really like like the editor, but now it is to much of a hassle getting it to work with Drupal and a image uploader. Wymeditor team is currently working on a media API, I am not sure if they are planning to release it with 0.5.

I hope someone step up and make 0.4 nicely with Drupal 5 or 6, this is really i compact and fast editor that are making clean and organized code, not like the tags in tinymce instead of (with Firefox) and even worse with Safari then it includes

Hi everyone,

To my knowledge, as of today, JQuery Update is still using JQuery 1.1.2 and thus can't help with WYMeditor 0.4 integration.

But this might change shortly, see this JQuery Update issue.

If so, I will rework and release a WYMEditor 0.4 module for Drupal 5. If not, I will focus on a Drupal 6 module.

Regards.

I use Drupal 5.x and lots of optional modules across various sites. I replaced the Drupal 5.x jquery with jquery 1.2.1 and everything still works including wymeditor-5.x-1.x-dev. I encourage you to create the WYMeditor 0.4 version for Drupal 5.x using jquery 1.2.1.

With Drupal 6 at beta 3 and not far from final release, the few 5.x modules that use jquery should be under development for 6.x and the changes could be backported to 5.x so those modules can use jquery 1.2.1 in Drupal 5.x. Create a new WYMeditor for 5.x and call it 5.x 1.2.1. Many sites can jump straight to jquery 1.2.1 and WYMeditor 0.4. The other sites can help upgrade the few optional Drupal modules that do not work with jquery 1.2.1 or stay with WYMeditor 0.2.

I have custom module running Wymeditor 0.4 on 5x. But there's a pretty big bug that has made it unusuable for my site. i've posted a bug on the Wymeditor site, but haven't heard about it yet. You can check out the issue here: https://trac.wymeditor.org/trac/ticket/87

hey gang.. i stumbled upon this looking for some Drupal 5 and jquery 1.2 compatibility help - and thought i would mention NO Dr 5 not comp with jq 1.2.. but mostly

i upgraded my site to 1.2 because the main docs on jq site were for 1.2 and very non-backward compatible.

this has been working fine for me except i just noticed the little "select all" check box on the admin/content page is missing.. after a little diggin around i tried replacing jq back to 1.1.. and sure enough thats the problem

i am not that concerned about that checkbox.. although i really do need it back - but i am more concerned about all the other things that might also be busted.. and worse.. that i dont get any js error from this.

I am working in this module to integrate with wymeditor 0.4 for drupal 5.x.
To do that, I started by updating jquery, according to the patches provided at jquery_update http://drupal.org/node/156221

(subscribe)

After upgrading the jquery to the most recent version using the jquery_update patch, I've done several changes and modifications, so WYMeditor could be upgraded to version 0.4

1. The configuration is now based on user roles instead of creating editor profiles
2. On the new profile window, several old functions where removed and new ones added (like the options to choose buttons and select plugins)
3. Instead of always returning JS inside the HTML, a js file is created according to user roles to use browser cache system
4. Allows the insertion of images, from the node attachments
5. A specific filter for WYMeditor is automatically created, and the allowed HTML is syncronized with the HTML tags selected for use within the editor

I post the code later...

Great Work!! :-D
Does this mean it will work with D6 without any updates of jquery? D6 will ship with jquery ver. 1.2.3 when it is done.

--
Stein Magne

(subscribe)

subscribe too

Hello, is this project dead or just suspended ? D6 already release and i tho that we could use wymeditor with d6. Any information will be appreciated.

Thanks.

subscribe

@asezen, #22:
I guess the WYMeditor project itself (www.wymeditor.org) is not making much progress at the moment. The latest version (0.4) is almost half a year old and the roadmap shows that version 0.6 is already 2 months late.
I would love to be able to use this module, but we can't expect the module developers to make progress if the core component doesn't.

The following patch adds support for version 0.4

This patch includes the wymeditor, but it can be easilly removed because i use the upstream version only with new files added. I was thinking in doing some organization to this... what do you think moxide?

PS: this is my first patch, so... be carefull!

Thank for your patch,
but i can't use it... I can't even figure out if i need to apply it against 5.x-1.x-dev or CVS, both fails...

The patch put a big mess but don't apply correctly!

Could you send the zip version of your work?

I think i will make a patch only for the wymeditor.module, wymeditor.js, wymeditor.install & wymeditor.info only.
And just copy the wymeditor folder (0.4 version) manually, it's better to do this way (in my opinion).

I really hope this module will not die... i'm ready to help to maintain... Drupal need such an editor!

The zip of wymeditor 0.4 for drupal-5.x

This version has some changes in the profiles of wymeditor, the profiles are associated to content filters

Thanks!

you answered quickly, i appreciate.

I've got some problems on install due to the old wymeditor (so for all the ones who want to test: uninstall manually wymeditor before testing this version: drop all wymeditor related tables = wymeditor_classes, wymeditor_containers, wymeditor_profiles)

Using filters is definitively a good way to setup nicely upon profiles!
Storing the containers and classes settings in variables is a great idea.

But there is still some bugs, i will post patches as soon as i have some time to do it.

The first things i've noticed:

You'll need to use jQuery 1.1.4, so on top of jquery_update, manually change the misc/jquery.js file with the most recent jquery version.
This seems to work great with others js module... plus, jquery 1.1.4 is really faster!

If not, you will have some stange behaviour in the editor: when creating new content or after a heading, the text isn't in a paragraph = it's raw text and you will be unable to make it append in a p tag without editing the HTML... strange!

Line 290 of the wymeditor.module:

      $container_js[] = "{'name': '".$container['tagname']."', 'title': '".$container['description']."', 'css': 'wym_containers_".$container['tagname']."'}";

is better like this:

      $container_js[] = "{'name': '".strtoupper($container['tagname'])."', 'title': '".$container['description']."', 'css': 'wym_containers_".strtolower($container['tagname'])."'}";

As we can't always be sure users will enter the tag name in uppercase, and the css name must be in lowercase.

And a little trick: jquery style baby.

jQuery(wym._box).find(wym._options.containersSelector)

it's better and faster to write it like that, as "wym._box" is a dom element, it can be used as context (see jquery doc):

jQuery(wym._options.containersSelector, wym._box)

fall_out, your work is awsome... really a great job!
This should be added as a beta in the module page... for a larger testing scale. (do you hear me Moxide?)
Thanks a lot!

I use this patch for the jquery update and work fine.

You need to create a patch with your corrections?

http://drupal.org/node/156221 #48

subscribe

Hi
Any patch soon?

Query_update module is picking up speed and have released a 5.x-2-branch that contain jQuery 1.2.3 so when this is done, we don't have to brake our Drupal installation to make the editor work and WYMeditor have finally started working in Safari ver 0.5-alpha is the first release that support Safari. I have done some light testing, and it is indeed promising.

Cheers
Stein Magne

And here it comes the work for WYMeditor 0.5-a1 (all the credits goes to fall_0ut)

New things in this version:
1. No more global permissions. Permissions are set against the input format permissions
2. We can turn off/on the WYMeditor at runtime using the filter formats radio buttons
3. No more right panel with classes and conatiners (we now have them as dropdowns (we will try to get this as an official WYMeditor patch)

For screens and video take a look at #125315: Textarea with input format attached

The patch was applied!