I was getting an undefined offset error in line 190 of slideshow_creator.inc. I believe this error is caused when not all parameters are passed in when using the block snippet. The array index should be explicitly checked for existence, and if it doesn't, return null.

CommentFileSizeAuthor
#2 slideshow_creator-D6-1466252-undefined-offset.patch4.21 KBrhouse
#2 slideshow_creator-D7-1466252-undefined-offset.patch4.17 KBrhouse
#1 fix.diff816 bytesmarkshust
bug.png48.52 KBmarkshust

Comments

markshust’s picture

markshust commented
Status: Active » Needs review
StatusFileSize
new fix.diff816 bytes

Fix attached

rhouse’s picture

rhouse commented
Status: Needs review » Fixed
StatusFileSize
new slideshow_creator-D7-1466252-undefined-offset.patch4.17 KB
new slideshow_creator-D6-1466252-undefined-offset.patch4.21 KB

Thanks markoshust, This was caused by a slideshow spec. that didn't follow the rules, but programs shouldn't crash on illegal input, so I did an examination of all the surrounding code. I also read the PHP experts on the correct usage of "empty". In short there were quite a few weaknesses that can be triggered by bad or unusual data. The attached patches (I hope!) fix them. These will go in the next version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.