These should be a checkbox that allows one to "hide" the follow link text or at least surround text with a class so that themers can hide it if needed. I like to just show the icons as clickable links.

CommentFileSizeAuthor
#7 1.png24.07 KBlikewhoa
#7 2.png19.54 KBlikewhoa
#1 follow-hidetext-1466720-1.patch3.47 KBkevincrafts

Comments

kevincrafts’s picture

kevincrafts commented
Status: Active » Needs review
StatusFileSize
new follow-hidetext-1466720-1.patch3.47 KB

Here's a patch that gives the option of hiding text. No theme modifications needed.

likewhoa’s picture

likewhoa commented
Status: Needs review » Reviewed & tested by the community

Works for Me. RTBC

cwithout’s picture

cwithout commented
Status: Reviewed & tested by the community » Needs work

I've always just done this in the theme, but I suppose it'll be easier for some people to have the option as part of the module.

I think if there's horizontal icons only option, there ought to be a vertical icons only option as well.

marktheshark’s picture

marktheshark commented

There is a problem with this solution:

Although setting in the text nicely hides it, it also causes the link title on hover show "Follow site on " (nothing).

It would be nice if the link title for the image could be decoupled from the link text.

likewhoa’s picture

likewhoa commented
Status: Needs work » Closed (fixed)

this is already committed upstream.

marktheshark’s picture

marktheshark commented

I have the latest 7.2.x from 2012-Sep-27 and #4 is still an issue.

Should I open a new issue for this?

likewhoa’s picture

likewhoa commented
StatusFileSize
new 2.png19.54 KB
new 1.png24.07 KB

@marktheshark works for me. see attachment.

marktheshark’s picture

marktheshark commented

Does the link title include the site name when hovering over the link?

likewhoa’s picture

likewhoa commented

@marktheshark when hiding text now, no link title is showing on mouse hover.

marktheshark’s picture

marktheshark commented

For me it shows: "follow site on ".

My thought was that it would be nice to be able to set the title (for the hover of the image link) and control the visibility of the text link via a checkbox.

likewhoa’s picture

likewhoa commented

you're right, i just didn't notice it. you should open a new issue then.