Hi,

I think a test would be useful for importing method.

CommentFileSizeAuthor
#6 1468680-6.patch6.53 KBkalman.hosszu
#4 1468680-4.patch5.47 KBkalman.hosszu
#3 1468680-3.patch5.63 KBkalman.hosszu
#2 1468680-2.patch5.74 KBkalman.hosszu
#1 1468680-1.patch4.43 KBkalman.hosszu

Comments

kalman.hosszu’s picture

kalman.hosszu commented
Status: Active » Needs review
StatusFileSize
new 1468680-1.patch4.43 KB

The test patch is attached. Please review it!

Kálmán

kalman.hosszu’s picture

kalman.hosszu commented
StatusFileSize
new 1468680-2.patch5.74 KB

I updated the patch with the following additions:

  • check that the other bundles are not selected
  • check directional importing
  • check transitive importing
  • check unique importing
  • check minimum and maximum arity importing

Kálmán

kalman.hosszu’s picture

kalman.hosszu commented
StatusFileSize
new 1468680-3.patch5.63 KB

The unselected bundle option method is changed.

kalman.hosszu’s picture

kalman.hosszu commented
StatusFileSize
new 1468680-4.patch5.47 KB

A little modification.

chx’s picture

chx commented

That looks good, thanks much. The only question I have, why are we testing machine name overrides? Is that something that relation does? I mean, I do not want to test ctools much. That's why we have the bundles tested, that's a relation thing.

kalman.hosszu’s picture

kalman.hosszu commented
StatusFileSize
new 1468680-6.patch6.53 KB

Yes the machine name is set in the validation function. I added a new section witch tests the import validation too.

Kálmán

chx’s picture

chx commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.