URL aliases require workaround

This work-around will only work if one has one search page.
In dynamic Url situation it will fail.
Like in my case. I have custom view for all taxonomy (categories) that use facet api for fields. Now here the alias would not work.
Can you give me any hint here how to get it work...

Any better solutions know yet?

Sory, it is not a soluttion.
Sub-path module seems to me looks from the END or url...
So if there are two or many facets - it is already don't work.

I have solution, but i don't know it is better or heavy for system:

I have views path taxonomy/term/%

module
Sub-pathauto
Sub-pathauto

admin/config/search/path/subpaths

choose
Maximum depth of sub-paths to alias = 4

And every facetted item - already with alias.a href=

I am using views with path taxonomy/term/%

It is critical to FIX alias of basepath ( for example alias of "taxonomy/term/%" ).

Search api ranges Slider - won't work. It using path, where it was chosen (alias). And when apply facet - with href taxonomy/term/38 ... Chosen facet get lost.

If it so hard to solve, maybe at the end of generating each facet item - we should use pathauto once more?

module Sub-Path helps, but choosing to check every path with big depth - it is maybe hard for system.

What is the status of this issue? I am facing the same problem with the website I am building.

Here's something that might be useful. I haven't tested it a lot as it turned out I don't need pretty paths any more. I tried it with terms using the provided Page Manager term page and with a search view containing a Page display on the term path.

I'm not sure of the implication of the loop in the inbound alter, e.g. performance and i18n. It tries to get the first valid source path by constructing possible aliases from the URL components.

/**
 * Implements hook_url_outbound_alter().
 */
function MODULE_url_outbound_alter(&$path, &$options, $original_path) {
  if (preg_match("|^taxonomy/term/(?'tid'[^/]*)/(?'rest'.*)|", $path, $matches)) {
    $tid = $matches['tid'];
    $rest = $matches['rest'];
    $path = drupal_lookup_path('alias', 'taxonomy/term/' . $tid) . '/' . $rest;
  }
}

/**
 * Implements hook_url_inbound_alter().
 */
function MODULE_url_inbound_alter(&$path, $original_path, $path_language) {
  $alias = '';
  $url = explode('/', $path);

  // Try to find a source path for the first valid alias.
  foreach ($url as $component) {
    $alias .= $component;

    if ($base = drupal_lookup_path('source', $alias)) {
      break;
    }

    $alias .= '/';
  }

  if (preg_match('|^' . $alias . '/(.*)|', $path, $matches)) {
    $path = $base . '/' . $matches[1];
  }
}

@malberts how are you handling subpages? If your term has children and those children are linked to content that is indexed, I think this won't work.
I used the following code

<?php
/**
 * Implements hook_url_inbound_alter().
 *
 * @param $path
 * @param $original_path
 * @param $path_language
 *
 * @return bool|string
 */
function my_module_url_inbound_alter(&$path, $original_path, $path_language) {

  $cache_data = &drupal_static(__FUNCTION__);
  if (!empty($cache_data[$original_path])) {
    $path = $cache_data[$original_path];
  }
  else {
    $cache = cache_get('url_inbound_search');
    if ($cache && !empty($cache->data[$original_path])) {
      // Look for cached result first
      $path = $cache->data[$original_path];
    }
    else {
      $cache_data = ($cache) ? $cache->data : array();

      // Run it through Sub-pathauto
      $result = subpathauto_url_inbound_alter($path, $original_path, $path_language);
      if ($result === FALSE || $result === NULL) {
        // If Sub-pathauto cant find anything, do the heavy lifting
        global $language_url;
        $path_language = $path_language ? $path_language : $language_url->language;

        $base_path_parts = explode('/', $path);
        $depth = count($base_path_parts) - 1;
        $path_suffix = array();
        // Loop over every part in the path
        for ($i = 1; $i <= $depth; $i++) {
          if (!$result) {
            array_unshift($path_suffix, array_pop($base_path_parts));
            $base_path = implode('/', $base_path_parts);
            // The base path is a part of the original path,
            // but in every iteration, the last part is sliced off

            if ($sourced_base_path = drupal_lookup_path('source', $base_path, $path_language)) {
              // If an alias for a part of the path is found
              // append the rest of it and return to sender (pun intended)
              if ($sourced_base_path != $base_path) {
                $path = $sourced_base_path . '/' . implode('/', $path_suffix);

                $cache_data[$original_path] = $path;
                cache_set('url_inbound_search', $cache_data);
              }
            }
          }
        }
      }
      elseif ($path != $original_path) {
        $cache_data[$original_path] = $result;
        cache_set('url_inbound_search', $cache_data);
      }
    }
  }

}
?>

@LammensJ, I never even thought of any of that. My only goal was to get single-level term pages (taxonomy/term/123) to work, but I ended up not needing pretty paths so that's just the result of my initial research. Yours looks much more comprehensive and includes the idea I had (looking up the alias manually).

#12 and #13 not work if we have hierarchy term alias

We must get last work alias not first!

i.e.

terms{
tid1 => term_name1
tid2 => term_name2
}

alias site.com/term_name1/term_name2/filter1/value1 ....

if we use #12 or #13 we get this urls (inbound hook):

1. term_name1/term_name2/filter1/value1
2. taxonomy
3. taxonomy/term
4. taxonomy/term/tid1 - stop here
5. taxonomy/term/tid1/term_name2 - not found

we must reverse search.

For me work:

function module_url_inbound_alter(&$path, $original_path, $path_language) {
    $alias = $path;
    $url = explode('/', $path);
    // Try to find a source path for the last valid alias.
    $found = false;

    foreach (array_reverse($url) as $key => $component) {
        if ($base = drupal_lookup_path('source', $alias)) {
            $found = true;
            break;
        }
        $component = "/".$component;
        $alias = str_replace($component,'',$alias);
    }

    if (preg_match('|^' . $alias . '/(.*)|', $path, $matches) && $found) {
        $path = $base . '/' . $matches[1];
    }
}

#18 in combo with the patch from https://www.drupal.org/node/1922086#comment-7087430 (applied to facetapi_pretty_paths 1.1, because it didn't apply to 1.4) fixes the issue for me of pretty paths not using the path alias in the base URL.

Here is the patch adding code from #21 as new base path provider and code from #18 with a separate setting.

Maybe we might separate base path URL and facet values with a special symbols instead of slash to avoid multiple drupal_lookup_path() calls?

@sin, your patch is missing the new plugin file: plugins/base_path_provider/facetapi_pretty_paths_alias_base_path_provider.inc

Here it is.

Patch #25 is working for me, good job guys!
Dont forget to change settings at 'admin/config/search/facetapi_pretty_paths' > 'Alias base path provider' & Use path alias in base URL

I have a view for taxonomy/term/% for my search API facets. Pretty Paths with Patch #25 kind of works for me, when I hover over the facet the URL displays correctly, but or some reason when I click it i'm 301'd to the taxonomy/term/tid version. Example:

Taxonomy Term Name: Gas Meter Rental
Path: taxonomy/term/93
URL Alias: rentals/gas-meter-rental

When I hover over a facet on the page, I see the correct path I want...heres an example for a facet on the gas meter rental page that sorts by a taxonomy term called "Parameter":

rentals/gas-meter-rental/parameter/carbon-monoxide-141

When I click on the facet, I'm 301'd to:

taxonomy/term/93/parameter/carbon-monoxide-141

Any ideas why this is happening? Please let me know if you need more information.

So I figured out my problem, it looks like the Global Redirect module is the culprit. When I disable the Global Redirect module, the fix in patch #25 works correctly. I tried disabling every setting in the module with it enabled, but that does not do the trick. I looked into the code for the global redirect module, when I comment out these lines everything works except for what this line of code is intended to do (removing unwanted trailing slashes):

Starts on line 215 of globalredirect.module
// Compare the request to the alias. This also works as a 'deslashing'
// agent. If we have a language prefix then prefix the alias
if ($request_path != $prefix . $alias) {
// If it's not just a slash or user has deslash on, redirect
if (str_replace($prefix . $alias, '', $request_path) != '/' || $settings['deslash']) {
globalredirect_goto($alias, $options);
}
}

Edit:
My workaround was to comment out this section, and in my .htaccess add:

RewriteRule ^(.*)/+$ $1 [R=301,L]

I am still learning a lot about drupal and programming in general (self taught)...That being said, I'm not really sure if there is a better solution. Any thoughts you may have about this are appreciated!

Patch #25 is working for me as well....
I don't make any changes at admin/config/search/facetapi_pretty_paths > 'Alias base path provider' & Use path alias in base URL
But I have to select 'Reuse term aliases' at 'admin/config/search/facetapi/search_api'

The patch in #25 also did not resolve this issue for me because of the global redirect module. I created a patch that should resolve this over here https://www.drupal.org/node/2813119#comment-11698659

@martini9011, are you saying you need both the patch in #2813119: Parameters added to path mess with redirect and this patch in order to solve this issue?

#25 patch works, thank you sin!

@pianomansam Yeah, that was the only way to resolve the issue for me

Confirm that #2813119: Parameters added to path mess with redirect works well with #25, thank you guys!

Confirm that patches #25 + #2813119: Parameters added to path mess with redirect works well.
Tested with search_api_ranges, two search pages (/search and /taxonomy/term/%).

#25 + #2813119 working for me

Using #25, when I create a menu link like : term-alias/segment/facet1, its alias is not used when I the link is displayed and instead the real path is savec and displayed : taxonomy/term/tid/segment/facet1.

Without the patch, it's actually impossible to create link with parameters. With the patch, it's possible, but the alias is not used.
Shouldn't the alias be used both for facet links and menus ?

Ok, using hook_url_outbound_alter() as explained before, my menu now uses the right aliases.

Confirming that #25 works. Thank you! RTBC+1