Hi iMiksu,

I started a sandbox with a tiny module, commerce_add_to_cart_popup that could fit into your commerce extras module. I was suggested in my full-project application to merge the module in to a bigger one. I leave the ref for you to consider.

Cheers,
ALessandro.

Comments

imiksu’s picture

imiksu
Location Finland
commented
Status: Active » Needs work

Hi ALMADEWEB!
I'm glad you're requesting this. I think this is the right place to merge.

I've tested your module and checked out the code. I also found a bug.

To merge the project into my project, there are steps to follow.

Step 1: Fix all bugs

Make sure there are no bugs found. I've actually found one and reported that: #1473150: Dialog disappears when selecting an attribute

Step 2: Renaming the module

The naming convention is: commerce_extra_[short-name]. In this case that probably would be: commerce_extra_add_to_cart_popup. If possible, you can try to invent something shorter, since commerce_extra_ prefix is already pretty long :S

Step 3: Make sure the code follows the coding standards

Obviously. I haven't checked that yet on your module. There are modules and scripts to help on this.

Step 4: Write how-to-use instructions

You can check how it's done in other sub-modules' README.txt file. Those instructions will be used in project page description too.

Step 5: Tell us about your plans on this feature

Is it feature-ready? Any milestones ahead? How much will you take care of that feature?

AlessMascherpa’s picture

AlessMascherpa commented

Hi iMiksu,

sorry for the delay responding your comment. The reason of it was that I thought that I could dedicate time to this module but I can't. That's why I'm seeking a new maintainer for the module. So, if you really want to include it in your commerce extra module, you can take it as it is and do it your own.

Cheers,
Alessandro Mascherpa.