This requires the Modal Frame API patch here: http://drupal.org/node/491224#comment-5693736

It works with jQuery 1.5.2 and jQuery UI 1.8.11. I've only changed a few lines as the code was pretty much D7 ready.

CommentFileSizeAuthor
#6 automodal-1469508-6.patch5.4 KBdrupallerina
#2 automodal-1469508-2.patch5.4 KBdrupallerina
#1 automodal_drupal7_port-1469508-1.patch2.41 KBimclean
automodal-drupal7-port.patch919 bytesimclean

Comments

imclean’s picture

imclean commented
StatusFileSize
new automodal_drupal7_port-1469508-1.patch2.41 KB

This includes the patch at #9 in #1007816: Exclude certian forms from closing dialogue (Automodal sometimes close immediatly) which works for me.

It also includes #6 patch in #1094620: confirm form 'cancel' doesn't work which I haven't tested.

drupallerina’s picture

drupallerina
she/her
Primary language German
Location Vienna
commented
StatusFileSize
new automodal-1469508-2.patch5.4 KB

here is a patch that incorporates some more changes as recomended by coder review

imclean’s picture

imclean commented

First glance shows at least one issue:

  Drupal.behaviors.automodal.attach = {
  attach: function (context, settings) {

This should probably be:

  Drupal.behaviors.automodal.attach = function (context, settings) {
imclean’s picture

imclean commented
Status: Needs review » Needs work

Better yet:

Drupal.behaviors.automodal = {
  attach: function (context, settings) {
drupalok’s picture

drupalok commented

could this be released as dev please?
thanks!

drupallerina’s picture

drupallerina
she/her
Primary language German
Location Vienna
commented
Status: Needs work » Needs review
StatusFileSize
new automodal-1469508-6.patch5.4 KB
drupallerina’s picture

drupallerina
she/her
Primary language German
Location Vienna
commented
Issue summary: View changes

Updated link to Modal Frame API patch.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
Status: Needs review » Fixed

Committed in 4c836c8. Thanks, @drupallerina! I'll make a 7.x-1.x-dev release soon - there's problems with Drupal.orgs release packager at the moment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.