_uuid_services_entity_access:entity_access always returns NULL for file entities as they do not have an access callback defined

Hmmm: http://drupalcontrib.org/api/drupal/contributions!entity!entity.module/f...

Return value
boolean Whether access is allowed or not. If the entity type does not specify any access information, NULL is returned.

I don't think hacking away file is a good generic plan. If it returns NULL it means there is no access information available so we just should return true. Entity module (or core or whatever module that is responsible) should add a callback for files.

Or am I missing something?

And a patch, that implements #1

That test always fails... even without this patch.

@aspilicious: we need to add a check to see if $return is !== FALSE, or we are just giving access to everyone for everything.

Something like that:

    $return = entity_access($op, $entity_type, $entity);

    // If there is no entity access information available, return TRUE.
    if (empty($return) && $return !== FALSE) {
      return TRUE;
    }

    return $return;

or check for === NULL

    $return = entity_access($op, $entity_type, $entity);

    // If there is no entity access information available, return TRUE.
    if ($return === NULL) {
      return TRUE;
    }

    return $return;

You're totaly correct!

Stupid tests, nothing to do with this patch

Hmm, I have my doubts here.

What if a module implements an access callback, and the access callback might be constructed in a way that it only returns TRUE when access is to be given and nothing (NULL) in all other cases. NULL in that case would mean access denied, but here we will let this through.

Maybe we should do something similar to what entity_access is doing -- fetch the entity info, check if we have 'access callback'. If we don't, always return TRUE. But if we do have an access callback return what that callback is giving us.

@dixon_ in the long run your solution looks the more appropriate.

I rolled and committed a patch with my logic explained in #10. I also took the opportunity to wrap more code in the try {} statement to catch potential errors in other parts of the access callback.

http://drupalcode.org/project/uuid.git/commit/22c3ae3f24e19ad411f14cb08b...

Thanks

There is a mistake in uuid_services.module:

elseif (!empty($entity_id)) {
      $entities = entity_load($entity_type, $entity_ids);
      $entity = reset($entities);
    }

Should be:

elseif (!empty($entity_ids)) {
      $entities = entity_load($entity_type, $entity_ids);
      $entity = reset($entities);
    }

Here's a patch to implement #14

+1 for RTBC

@dillix, @CarlHinton Please don't re-open a Closed (fixed) issue. Instead, you can open a new issue with your patch. Setting metadata back to the closed values.