Using core upload and taxonomy modules is an idea I like very much. The module seems to work as advertised but... there are lots of errors. This is what I see when looking at /?q=docs

    * warning: Missing argument 1 for docs_browser() in /home/drupal/test2/sites/all/modules/docs/docs.module on line 106.
    * warning: Missing argument 2 for variable_get(), called in /home/drupal/test2/sites/all/modules/docs/docs.module on line 95 and defined in /home/drupal/test2/includes/bootstrap.inc on line 369.
    * warning: Missing argument 2 for variable_get(), called in /home/drupal/test2/sites/all/modules/docs/docs.module on line 96 and defined in /home/drupal/test2/includes/bootstrap.inc on line 369.
    * warning: Missing argument 1 for docs_node_info() in /home/drupal/test2/sites/all/modules/docs/docs.module on line 389.
    * warning: array_shift() [function.array-shift]: The argument should be an array in /home/drupal/test2/sites/all/modules/docs/docs.module on line 390.
    * warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in /home/drupal/test2/modules/node/node.module on line 1990.

Any ideas?

Comments

Christefano-oldaccount’s picture

Christefano-oldaccount commented
Title: Errors » docs.module works, but has many errors
Version: » 5.x-1.0-alpha

I looked through the code and it looks good, but I'm still not entirely sure about all the errors. I replaced the array_shift with foreach loops but wasn't able to fix everything.

I'm really looking forward to using this!

dikini’s picture

dikini commented
Assigned: Unassigned » dikini
Priority: Minor » Normal

Hmm, looks like there are two issues there. The first one is related to the forms at root, I'll update cvs a bit later today. The secon one looks like it is upload related. I need to investigate it a bit more. Bear with me on it:)

dikini’s picture

dikini commented

Updated in CVS. I think, most of the errors at least.

FYI. The first one, the one around line 106 and friends was to do with a bit of sloppiness on my part in dealing with the root of the vocabulary.

The second - is a deeper thing related to the file upload form and enforcing at least one file attachment. It's a gray area, how to deal with that, but I'll try to resolve it separately. If you confirm that this is the only outstanding issue, I'll flag this issue as fixed and op[en a separate one for upload, since it is not just another sloppy coder bug.

dikini’s picture

dikini commented
Version: 5.x-1.0-alpha » 5.x-1.0-alpha2
Status: Active » Fixed

fixed in the second alpha

Christefano-oldaccount’s picture

Christefano-oldaccount commented

Great, thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)