Basically:
drupal_alter('mixpanel_defaults', $defaults);

Should be:
drupal_alter('mixpanel_defaults', $defaults, $user);

CommentFileSizeAuthor
#1 0002-Fixes-1470632-Code-cleanup.patch1.38 KBwundo
#1 0003-Function-mixpanel_get_defaults-receives-instead-of.patch814 byteswundo

Comments

wundo’s picture

wundo commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new 0003-Function-mixpanel_get_defaults-receives-instead-of.patch814 bytes
new 0002-Fixes-1470632-Code-cleanup.patch1.38 KB

Patch attached

kyle_mathews’s picture

kyle_mathews commented

Hey, do you remind re-rolling your patches? I made some commits tonight to fix some other things and your patches aren't applying anymore.

Also, if it's not too much trouble, it's easier to just merge in your changes than to apply patches. Especially if you plan on make a number of other changes.

wundo’s picture

wundo commented

Hi Kyle, merging is easier indeed, the only thing is that I will need access to the project repo :)

Also, I'm pushing my changes to this Sandbox:
http://drupal.org/sandbox/wundo/1462666

kyle_mathews’s picture

kyle_mathews commented

Actually you don't! Git is magic!

I can just add your Sandbox repo as a remote repository and merge your changes in. And you can track my changes by doing the same with the "official" Mixpanel repo.

http://book.git-scm.com/3_distributed_workflows.html

kyle_mathews’s picture

kyle_mathews commented

Anyways, I've looked at your sandbox some more and I like what I say! I like how you've broken out the various default tracking things into separate include files. Much cleaner.

How about you just tell me when you're done making changes and I'll merge in your stuff, do a bit of testing and make a new release?

Or actually, if you'd like, I can just make you a co-maintainer and you could do the merging yourself! Especially if you'll be using / working with this code for awhile.

wundo’s picture

wundo commented

I've already merged your changes to my sandbox.

About my roadmap, well, I'm planning to write a queue integration for Mixpanel and also get rid of that exec call.
After that, in like 5 months from now, I will need a D7 version of the module for my own use.

kyle_mathews’s picture

kyle_mathews commented

Sounds awesome! I've gone ahead and made you a maintainer. So feel free to make the changes you've suggested, roll releases, etc. Ping me if you want me to review anything but in general, you seem trustworthy and I'm not really using the module anyways so you can take over steering this module forward.

wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Fixed

I've spent half an hour merging my changes to the main branch, I think I haven't break anything :)

kyle_mathews’s picture

kyle_mathews commented

Heh, Good to hear :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fixing typo