Hi,

the function openid_provider_authentication_response() has been deleted (d6 and d7). There is a comment about that by anarcat in another issue and there were some comments in the code (before it had been deleted), i'd like to cite :

- * It is unclear what this function is for. It is not used anywhere,
- * and looks like a "10.1. Positive Assertions", but that's what
- * openid_provider_authentication_response() does...
- *
- * This is basically a copy of openid_redirect_http() but it does a
- * full HTTP request directly from the browser.

This function is used for example by OpenID Provider AX (which is broken right now) and basically tests if the relying party, where to send the attributes to, is available. Of course this could be implemented within the depending AX module, but it might be used by some other modules as well, that's why i guess it was in the OpenID Provider module.

Anyway, the function might not be the best code so far :-) But deleting it breaks depending module(s), so it should not be done without deeper discussion. IMHO it would be the best way to re-add the function to the module and then let's find the best solution.

Comments

xamanu’s picture

Here is the patch, for D6. But anyway it is just adding the function so it should be done within seconds for D7 as well.

sanduhrs’s picture

anarcat’s picture

Status: Active » Fixed

oops! sorry! now I know what it's for ;)

I have reverted and pushed this change back into place, will make an RC shortly.

sanduhrs’s picture

Thanks alot!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.