When using the group-specific search or people search, the appropriate ApacheSolr query string isn't added and the search isn't refined.

Comments

ezra-g’s picture

Title: Group and user search doesn't filter appropriately with ApacheSolr » Group search doesn't filter appropriately with ApacheSolr
Status: Active » Needs review
StatusFileSize
new1.7 KB

It's not clear to me if this feature worked previously.

I tested this patch with a local ApacheSolr setup.

In general I'm not clear on when case 'type': would come into effect and I feel like this code has the potential to be refactored for increased readability.

This patch also corrects a call to menu_get_item() which had an unnecessary parameter.

ezra-g’s picture

StatusFileSize
new1.75 KB

I couldn't handle the $group = NULL;

I've moved further nitpicks into #1472226: commons_core_form_search_theme_form_alter() nitpicks.

ezra-g’s picture

Status: Needs review » Needs work

Those are both the wrong patches from the ones I tested and meant to upload.

Correct patch coming after this short caffeine break ;).

ezra-g’s picture

Status: Needs work » Needs review
StatusFileSize
new2.04 KB
ezra-g’s picture

StatusFileSize
new2.53 KB

As it turns out, B) from #1472226: commons_core_form_search_theme_form_alter() nitpicks is necessary in some cases to make sure that apachesolr_search doesn't override the submit handler for the search_theme_form().

ezra-g’s picture

Status: Needs review » Needs work

When no group is specified, the site falls back to core search.

ezra-g’s picture

Issue tags: +Commons 2.6 radar

Tagging for triage for the 2.6 release.

ezra-g’s picture

Status: Needs work » Needs review
StatusFileSize
new5.09 KB
ezra-g’s picture

Status: Needs review » Fixed

Following some additional testing, #8 is committed. http://drupalcode.org/project/commons.git/commit/87d3810ad9b849eeb6ae13c...

Automatically closed -- issue fixed for 2 weeks with no activity.