Field collection uses the entity_i18n_string() for translations, but they've removed that function in their latest dev release.

To come, a patch that defines our own i18n_string() and updates references.

CommentFileSizeAuthor
#1 replace_entity_i18n_string-1471840-1.patch2.75 KBfakingfantastic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fakingfantastic’s picture

fakingfantastic CreditAttribution: fakingfantastic commented
FileSize
replace_entity_i18n_string-1471840-1.patch2.75 KB

Patch with new field_collection_i18n_string() method and references to entity_i18n_string() replaced.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented
Status: Active » Needs work

Patch applies correctly and works as advertised. One more review and it's RTBC. Nice work Frank!

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented
Priority: Normal » Major
Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

Subscribe. Patch was applied correctly. Please, commit it to 7.x-1.x-dev.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented
Status: Needs work » Reviewed & tested by the community

That makes this RTBC.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented

Field collection uses the entity_i18n_string() for translations, but they've removed that function in their latest dev release.

!? I've not.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Reviewed & tested by the community » Needs work
Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

@fago,
Entity API 7.x-1.0-rc1 (latest release) doesn't contain entity_i18n_string() function. Even when Entity API will have newer release including this function, patch should be applied anyway for support old-version of Entity API.

At the moment, if you create new release of Field Collection, module won't work at all (until Entity API 7.x-dev is not installed).

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented

Exactly, the latest version of Entity API no longer contains the function entity_i18n_string() and the patch in #1 creates it again for Field Collection.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs work » Closed (works as designed)

Wrong, the latest (dev) version contains the code. The rc1 is too old.

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

You right, rc1 is old and dev version contains the funtion. But most users get used to download stable release, not a development version. And in this case they will got a WSOD.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin commented
Status: Closed (works as designed) » Active

so setting active such that sufferers can find it until #1480282: Create a new stable release is fixed.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Title: entity_i18n_string has been removed » field collection dev requires entity api dev version
Status: Active » Postponed

Well if you can use the field-collection dev version, you can do it for the entity api too.

Setting to be postponed, as it depends on #1480282: Create a new stable release.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Postponed » Fixed

This was already taken care of by http://drupal.org/node/1512478 I believe.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.