User interface text containing URLs in translated part

Thanks! The patch is mostly correct, but I found two problems:

a)

-      $description = t('Your server is capable of displaying file upload progress, but does not have the required libraries. It is recommended to install the <a href="http://pecl.php.net/package/uploadprogress">PECL uploadprogress library</a> (preferred) or to install <a href="http://us2.php.net/apc">APC</a>.');
+      $description = t('Your server is capable of displaying file upload progress, but does not have the required libraries. It is recommended to install the <a href="@uploadprogress_url">PECL uploadprogress library</a> (preferred) or to install <a href="@apc_url">APC</a>.', array('uploadprogress_url' => 'http://pecl.php.net/package/uploadprogress', '@apc_url' => 'http://us2.php.net/apc'));

uploadprogress_url is missing @ in the replace array.

b)

-      $output .= '<dd>' . t('By default, the Search module only supports exact keyword matching in content searches. You can modify this behavior by installing a language-specific stemming module for your language (such as <a href="http://drupal.org/project/porterstemmer">Porter Stemmer</a> for American English), which allows words such as walk, walking, and walked to be matched in the Search module. Another approach is to use a third-party search technology with stemming or partial word matching features built in, such as <a href="http://drupal.org/project/apachesolr">Apache Solr</a> or <a href="http://drupal.org/project/sphinx">Sphinx</a>. These and other <a href="@contrib-search">search-related contributed modules</a> can be downloaded by visiting Drupal.org.', array('@contrib-search' => 'http://drupal.org/project/modules?filters=tid%3A105')) . '</dd>';
+      $output .= '<dd>' . t('By default, the Search module only supports exact keyword matching in content searches. You can modify this behavior by installing a language-specific stemming module for your language (such as <a href="@porterstemmer_url">Porter Stemmer</a> for American English), which allows words such as walk, walking, and walked to be matched in the Search module. Another approach is to use a third-party search technology with stemming or partial word matching features built in, such as <a href="@solr_url">Apache Solr</a> or <a href="@sphink_url">Sphinx</a>. These and other <a href="@contrib-search">search-related contributed modules</a> can be downloaded by visiting Drupal.org.', array('@contrib-search' => 'http://drupal.org/project/modules?filters=tid%3A105', '@porterstemmer_url' => 'http://drupal.org/project/porterstemmer', '@solr_url' => 'http://drupal.org/project/apachesolr', '@sphinx_url' => 'http://drupal.org/project/sphinx')) . '</dd>';

@sphinx_url is misspelled as @sphnik_url in the t() text.

Looks good then, thanks!

Actually, since the tests passed even with the errors I found in #2, I think this either needs some automated tests or some manual testing before we can say for sure that it's OK.

I think I had the wrong testing tag

#3: translated-urls-1471848-3.patch queued for re-testing.

Hmmm. Dan Silver: I just hit Retest to see if the test bot has the same problem. You might want to try downloading the patch again, just to make sure...

OK, looks like the patch above needs a reroll.

Hey BassistJimmyJam -- Thanks for the patch reroll!

But ... Dan Silver had assigned the issue to himself that same day. Next time, it would be more polite to find an issue that someone hadn't already claimed by assigning it to themselves. Or at least post to the issue and ask if they are still working on it (for instance if someone assigned it to themselves a week ago and there hasn't been any action on it), and if there is no response in 24 hours, then you can assign it to yourself to indicate that you are working on it. Thanks!

Meanwhile, we still need someone to test this patch manually, since there were errors as noted in #2, and they didn't cause any automated tests to fail. We need someone to figure out where all of these are displayed, and verify that the links work.

See #17. Patch still needs *manual* testing.

Looks like this patch needs a re-roll.

Also, over on #692366: Stop forcing language/mirror for PHP manual links we were just discussing that in Drupal 7, we would also like this change made (at least for the file.install strings), so I am marking this for backport.

RE #35: I think we should just fix those two with the PHP languages that we need to fix on the other issue. In which case, we *could* just fix them on the other issue?

Thanks for making this patch!

It needs a bit of work:

a) The first hunk still has us.php.net in the URL. We should take that out, see #692366: Stop forcing language/mirror for PHP manual links
b) The second still has 'en' in the URL. We should take that out, see above.
c) The third hunk -- see #35 - for Drupal 7 we decided we are not removing the URLs except for the ones that have us.php.net or php.net/en in the URLs, so that one should be skipped (and probably most of the rest of the patch).

I guess I wasn't clear in my last review... Changes like this:

-    $requirements['php_register_globals']['description'] = $t('<em>register_globals</em> is enabled. Drupal requires this configuration directive to be disabled. Your site may not be secure when <em>register_globals</em> is enabled. The PHP manual has instructions for <a href="http://php.net/configuration.changes">how to change configuration settings</a>.');
+    $requirements['php_register_globals']['description'] = $t('<em>register_globals</em> is enabled. Drupal requires this configuration directive to be disabled. Your site may not be secure when <em>register_globals</em> is enabled. The PHP manual has instructions for <a href="@url">how to change configuration settings</a>.', array('@url' => 'http://php.net/configuration.changes'));

We need to leave these out of the patch for D7. The URL that is in the text here is correct (it doesn't have 'en' or 'us' as part of the URL), and because changing translated strings is disruptive, for D7 we are only changing translated strings to remove URLs if there is also a problem in the URL. So this change, and others like it, need to be removed from the patch.

Thanks!

Thanks!

Since this text goes into the user interface, we need someone to test and verify that all of the links that are updated here still work, and that the formatting on those pages comes out correct.