MySQL warning when installing Tasklist Advance 5.x-1.0

hydrian - May 27, 2007 - 12:57
Project:Tasklist Advanced
Version:5.x-1.0
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I recieved the warning when installing TLA:

user warning: Table 'blazeknight_vault.tasks' doesn't exist query: INSERT INTO drupal_tasks_advanced (nid, taskcategory, tasktype) SELECT t.nid, 'unknown', IF(t.nid IN (SELECT parent FROM tasks), 'project', 'action') FROM drupal_tasks t LEFT JOIN drupal_tasks_advanced a ON t.nid = a.nid WHERE ISNULL(a.nid) in /home/.mugs/bkvdaemon/blazeknightsvault.com/includes/database.mysql.inc on line 172.

I verified that I don not have the table blazeknight_vault.tasks. After looking at my mysql DB, It looks like the database is using a different naming standard. The names I saw in the database are the following
drupal_tasks
drupal_tasks_advanced

These tables are also in sync with every other naming convention in my db.

I am using:
Drupal 5.1
Tasklist 5.x-1.0
Tasklist Advanced 5.x-1.0

#1

moonray - June 19, 2007 - 18:12

Have you tried the HEAD version? I believe it's fixed there.

#2

tom friedhof - July 31, 2007 - 00:28

It's not fixed in the head version. Looks like there was a schema change in the tasks module about 6 weeks ago so that the "parent" field in the tasks module wouldn't conflict with "parent" in book module.

Here is the patch to fix this module.

AttachmentSize
schema_fix.patch3.6 KB

#3

tom friedhof - July 31, 2007 - 00:28
Status:active» patch (reviewed & tested by the community)

It's not fixed in the head version. Looks like there was a schema change in the tasks module about 6 weeks ago so that the "parent" field in the tasks module wouldn't conflict with "parent" in book module.

Here is the patch to fix this module.

#4

TallDavid - August 9, 2007 - 15:13

Applying the patch failed on my installation. Rather than troubleshooting why the patch failed, could we get the fix committed/released in the current development version.

#5

do - August 11, 2007 - 07:39
Status:patch (reviewed & tested by the community)» won't fix

I could apply the patch, afterwards my apache2 starts to "segmentation fault" when I try to enable the module. Something is pretty wrong here.

#6

Lenn-art - August 12, 2007 - 12:36

How do i use this patch?

#7

sanchehl - August 14, 2007 - 18:28

Does anyone have this working yet. I get the same error message. I tried applying the patch but like many other Windows users, i can't get the patch to apply. I tried to do it manually, but i get errors, i'm missing something somewhere. Can someone post the fixed files for download? i would really like to see how this module enhances the base task module.

#8

Lenn-art - August 19, 2007 - 19:57

No one? I think, this is a important problem, because there are at least two duplicates of this problem reporterd in the issues. So, more people have this problem? Maybe some of the coders can give us a status update, so that we know what we are up to :-)

#9

Wrath-BRIG- - September 11, 2007 - 03:37

We're getting the same error. But since we're using a commercial web host, I'd rather not try a patch that might cause an Apache segmentation fault. Our provider might flip out. LOL Sorry I don't have anything to significant contribute But perhaps details about my platform and configuration might be helpful.

  • Tasklist: 5.x-1.2
  • Advanced Tasklist: 5.x-1.0
  • Running Drupal: 5.2
  • MySQL database: 4.1.22
  • PHP: 4.4.7
  • Unicode library: PHP Mbstring Extension
  • Web server: Apache/1.3.37 (Unix) mod_auth_passthrough/1.8 mod_log_bytes/1.2 mod_bwlimited/1.4 FrontPage/5.0.2.2635.SR1.2 mod_ssl/2.8.28 OpenSSL/0.9.7a PHP-CGI/0.1b
  • Wrath-BRIG-
    http://dfbrigade.org

#10

arif_mandra - October 31, 2007 - 12:30
Status:won't fix» patch (reviewed & tested by the community)

Hereby, I have updated the code of the module file for solving that SQL bug. It is working fine for me. I have tested it. Kindly, test this file and let me know if you have any problem with this.I have added tasks_advanced.module file as tasks_advanced.module.txt file , so rename it as tasks_advanced.module file once you download it.

AttachmentSize
tasks_advanced.module.txt32.84 KB

#11

dami - October 31, 2007 - 17:10
Priority:normal» critical

Bump this issue to critical. Because of the schema changed in tasks.module. The 5.0 version of this module is basically unusable. At a fresh install, it would complain about "unknown column parent ...".

I haven't tried the patch in #2, but it's a simple patch and I believe it should fix it. However, looks like the maintainer of this project has been inactive for a while (last commit was 32 weeks ago). We are somewhat stuck, unless someone would step up committing the patch.

#12

arif_mandra - November 1, 2007 - 05:43
Category:bug report» task
Status:patch (reviewed & tested by the community)» patch (code needs review)

Hi , I have updated the module code as per the schema in Task module version 5. I have attached the code previous post here. It is working fine for me. Can some body use that module file code and get back to me if they find any error. I have uploaded whole module file as txt file in previous reply. You need to just download the file and just rename it as .module file.

#13

dami - November 1, 2007 - 16:28
Status:patch (code needs review)» patch (code needs work)

@arif_mandra: Your code works fine, except a couple typos. I tried it yesterday briefly, and had to fix a couple typos like 'tas' to 'task' etc (can't remember exactly what I changed now.).

The .install file also needs to be patched for a fresh install to work. I am setting this to "code needs work".

#14

dami - November 1, 2007 - 16:32
Status:patch (code needs work)» patch (code needs review)

Just noticed #2 patch actually includes all the changes needed. It looks good to me, I'd say 'ready to commit'. But I am on windows now and can't confirm if the patch really works. Just setting it to 'code needs review' for now.

#15

bonaparte - November 6, 2007 - 21:44

arif_mandra,

Your patch works fine. Thank you so much. Is this possible to mention this in the README file of the module?

#16

schultz - November 15, 2007 - 03:33

How long before this patch be committed? I would like to use it.

#17

arif_mandra - November 20, 2007 - 05:19

Hi Schultz,

I am little bit busy these days, once I get the time than I will commit the patch.

#18

AgnesCB - January 18, 2008 - 01:08
Status:patch (code needs review)» patch (reviewed & tested by the community)

The modified file in #10 doesn't include needed changes to the install file and has typos. Not ready for commit.

The patch file in #2 is correct, but tries to do one better and fix an apparent typo at line 625. But this is not a typo, although it really, really looks like one. That extra fix causes the rebuild_tree function called by the install script to go into an infinite recursive loop and makes Apache core dump, per #5 and my own observations.

I am including a corrected version of the patch from #2 with a slight modification to the module file to clarify the syntax that led to the mistaken fix and the core dump.

This has been tested with Drupal 5, a new install of the current versions of tasks (5.x-1.2) and of tasks_advanced (5.x-1.0). It will not work as is against HEAD (version 1.17 of tasks_advanced.module).

AttachmentSize
tasks_advanced_patch.txt4.29 KB

#19

AgnesCB - January 18, 2008 - 01:10
Category:task» bug report

#20

martinship - March 11, 2008 - 09:55

AgnesCB, thanks for polishing up the code on the patch. I was able to install tasklist advanced successfully on drupal 5.7 using tasks 5.x-1.2 and tasks_advanced 5.x-1.0 (after applying the patch from #18). I'm happy to report the patch has received a through workout on my development install.

#21

moonray - April 3, 2008 - 17:12
Status:patch (reviewed & tested by the community)» fixed

The patch needed some tweaks. Fixed in CVS.
Thanks everyone for your contributions, and my apologies for not getting this committed sooner.

#22

Anonymous (not verified) - April 17, 2008 - 17:22
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.