So, I noticed that we have some cruft in CSS that never bothered me:

/*
 * Prevent overflowing content
 */
#header,
#content,
#navigation,
.region-sidebar-first,
.region-sidebar-second,
#footer,
.region-page-closure {
  overflow: visible;
  word-wrap: break-word; /* A very nice CSS3 property */
}

I decided to investigate what it actually did, so I set my time machine back to 2007. It comes from #110897: oversize content causes IE6 layout breakage, which is a IE specific bug. Let's see what are the defaults according to modern browser implementations:

So it seems overflow: visible should move to ie6.css, while word-wrap: break-word should be applied only to the sidebars (I don't believe a word will span across any other region), and since 6.x-2.x (at least) we can target it with .sidebar.

Comments

barraponto’s picture

btw, this can be safely ported to 6.x-2.x

johnalbin’s picture

Version: 7.x-3.x-dev » 7.x-5.x-dev
Assigned: Unassigned » johnalbin

I'm willing to tackle this in 7.x-5.x.

Yes, word-wrap: break-word; was added to work around that IE bug. But it is a useful feature on its own. I'm going to leave that be.

But I agree that overflow: visible; doesn't need to be set for all browsers. And IE6 is already getting a variant of overflow set for it.

johnalbin’s picture

barraponto’s picture

Do we really need to word-wrap: break-word *every* region?

johnalbin’s picture

Do we really need to word-wrap: break-word *every* region?

It's per grid item now, not per region.

Is there a specific annoyance with this property? It's one line of CSS applied to all grid items in a single ruleset. Its just a couple bytes.

barraponto’s picture

Yes, but it breaks words. I noticed this because someone posted a screenshot to #drupal-themes with a content region scrambled because of a bad implementation of break-words support in an specific version of Safari. I know it will hardly show up again, but it is not useful at all in 7.x-3.x besides sidebars.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.