This patch includes a style-rtl.css files with cascading rules for the bluemarine theme, to take advantage of the new method to include RTL styles in themes and modules, as described here: http://drupal.org/node/145737

Bluemarine is a table based theme, so notice the following issues:
- Since directionality has changed to RTL, the order in which the cells are laid out, is from right to left, thus creating a true mirror effect.
- Be not misguided though, as the mirror effect doesn't really change the names of the columns, so if you put something in sidebar_left, it will appear on the right side. Not a disaster, but good to know ;-)

CommentFileSizeAuthor
#12 bluemarine_rtl_0.patch3.19 KBz.stolar
bluemarine_rtl.patch3.19 KBz.stolar

Comments

yhager’s picture

yhager commented

Just a quick one. Instead of 

+ul.links li {
+  border-right: 1px solid #9cf; 
+}

I suggest

+ul.links li {
+  border-left: inherit;
+  border-right: 1px solid #9cf; 
+}

Although I haven't tested.. ;)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

So you have the table cells reordered with direction: rtl? (Also please get people from the Arabic groups to review :)

z.stolar’s picture

z.stolar commented

yhager: you're right about the inherit.
Gabor: I addressed the arabization group: http://groups.drupal.org/node/3545#comment-12516

The table cells are not reordered, but they are rendered from right to left. That's exactly the issue: it gives you a mirror effect, because right becomes left and vice-versa, but the actual code doesn't change, and that's why you get your right sidebar on the left. This is confusing in the first time, but it's really a bug one can live with (for a while ;-) ) until we fin another solution. Or we might decide that table based themes, being already non-standard, are not worthy to be treated nicely :D

Nevertheless, I admit that it was nice to apply the patch and see how the whole site changes sides, just by changing it's language, without me having to write special functions for that, like we do in 4.7 or 5 sites.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Nevertheless, I admit that it was nice to apply the patch and see how the whole site changes sides, just by changing it's language, without me having to write special functions for that, like we do in 4.7 or 5 sites.

Yes, I hope to win a lot more warm hearts with Drupal 6 ;)

Anyway, how regions of a CSS based theme are different then a table based theme? Both will have their 'left' region displayed on the right in RTL mode, right? So this seems to be rather a documentation issue. For sites having both LTR and RTL languages, this is a livable situation IMHO, not a bug. It would be quite complicated to have controls for blocks per theme per language direction. For RTL only sites, it is indeed an interesting situation, but I don't have a good idea on how to make this more more user friendly.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Here is a test site by levavie: http://dev.drupal.org.il/he/node It also includes the language switcher block set up (http://drupal.org/node/141996)
So let's fix what yhager complained about and get levavie or someone else review the results.

yched’s picture

yched commented

Looks like primary tabs have a display issue :
http://dev.drupal.org.il/he/user/register

z.stolar’s picture

z.stolar commented

This is something I couldn't beat.
The only noticeable thing I could observe is, using FireBug, if I look at the english(LTR) version, adding
text-align:right
to the ul.primary, renders the tabs correctly on the right side. I couldn't redo it in the RTL version... :(

I suspect it to come not from the RTLed theme CSS, but from one of the core modules' styles.

yhager’s picture

yhager commented

yched: Can you elaborate on the issue you're having?

If it is the tabs being displayed too close to one another, they are rendered correctly in Opera, IE6 and Konqueror (Safari?).

With Firefox, there is Firefox bug #121633, which is marked as fixed. If I understand correctly, the fix will be released with Firefox 3.0 (2007/Q4).

z.stolar’s picture

z.stolar commented

I confirm IE7 is fine too.
Sadly enough, this seem like a FF bug.

yched’s picture

yched commented

@yhager : Er, yes, my bug description was rather short, sorry.
It was actually the tabs displayed too close on FF - I don't read hebrew so I could not tell whether they were overlapping or just sticked together.
If its a FF bug, then forget it :-)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

OK, if we get a fixed patch with the inherit issue corrected, seems like the patch is good to go. Levavie already tested it and had no problems as far as I know.

z.stolar’s picture

z.stolar commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new bluemarine_rtl_0.patch3.19 KB

Added
border-left:inherit;
to ul.links in style-rtl.css

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

OK, applied this patch to a test site, tried with right-to-left rendering, and I did not notice problems. Committed!
Awaiting styles for further themes! :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Pushbutton styles are developed here: http://drupal.org/node/148084 Please help review and test the styles.
I would also welcome more work on other core themes. Marvin and Chameleon should be easy (simple and similarly table based as Bluemarine), and Garland/Minnelli would be really cool to be able to be able to perform the *installation* of Drupal in an RTL language. Rock on, there is still time to do this for Drupal 6!

yhager’s picture

yhager commented

There you go Marvin and Chameleon: http://drupal.org/node/148943

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)