Remove i.e. and e.g. from node.tpl.php

Actually, the correct text should be [note punctuation!]:

node: The current template type; e.g., "theming hook".

The reason is that "e.g." means "for example". "i.e." means "that is", and you are perfectly right, it is misused in the node: text.

Actually, I'd prefer not to use either of them. How about:

node: The current template type; for example, 'theming hook'.

Anyway, just go ahead and make one patch with all the places you've spotted. We can deal with rerolling it. If it is only a few places, there's a good chance it can just get committed.

I'm assuming this should be unassigned so someone else can pick it up? Feel free to assign it back if you still want to work on it.

what i have done in this patch is to change the eg, to for example as what on comment #1 have said

you can also add other possible changes on the documentation so that i can re-roll and make a new patch again

Thanks.

Thanks! But the patch you uploaded contains the fix for another issue along with the fix for this issue.

Also, the original report mentioned finding this problem elsewhere in the documentation. So if you wanted to do even more, you could use "grep" to find other places with "i.e." in the documentation, see if they are also wrong, and fix them in a similar way.

It's good novice issue for me so as to I start to know the drupal core development deeply that's why I worked on this and attached a patch.

Actually, let's get rid of all i.e. and e.g. in the documentation, in this patch. They're more often misused than used correctly, and so many people are confused about what they are... i.e. we shouldn't probably even need at all, and we can replace e.g. with "for example" where it is actually necessary. In the rare case that i.e. is actually needed, use the English "that is".

Regarding "do not test" -- all new patches that are supposed to be committed must be tested. Period. As a committer, that makes me more confident that there wasn't a small syntax error in the patch that completely breaks core. Thanks!

So, my suggestion would be for a few of the changes in this patch:

- *   The type of the item (i.e. theme, theme_engine, module, profile).

Take out the "i.e.", and say "(theme, theme_engine, module, etc.)" instead. This actually *could* be "that is", but anyway the punctuation was wrong.

-  // installed yet (i.e., if no $databases array has been defined in the
+  // installed yet (i.e. if no $databases array has been defined in the

This change in puncutation is incorrect, IMO, and I think we can just leave out i.e. here entirely.

- * If a destination was specified in the current request's URI (i.e.,
+ * If a destination was specified in the current request's URI (e.g.,
  * $_GET['destination']) then it will override the $path and $options values

This really was "that is" not "for example" I think. I think it should be reworded to say:

If $_GET['destination'] was specified in the current request, then it will override the $path...

So, all of these changes will need a bit of thought... but I think we'd be better off without using either e.g. (which is almost always mis-punctuated) or i.e. (which is often used to mean e.g. by mistake, and in the rare case when it's used correctly, is misunderstood by the majority of people who think it means e.g.).

Looks like this file has changed since the last patch, but here's my attempt at getting rid of all the e.g. i.e.s.

Looks pretty good! One mistake:

- *   - view-mode-[view_mode]: The View Mode of the node e.g. teaser or full.
+ *   - view-mode-[view_mode]: The View Mode of the node; that is, teaser or full.

This one should be "for example", and the examples should be in '' quotes.

Otherwise, looks fine. The other thing we should do is make the same changes in bartik's node.tpl.php and any other node.tpl.php files in core. Thanks!

I don't think I realized that D7/8 had the ability to add additional view modes! Good to know.

And for Bartik.

The patch in #17 looks good to me and to the test bot, but I cannot get it to apply to the latest 8.x. I think it just needs a reroll-- looks like some templates got updated recently.

Rerolled attached.

I also wrapped some lines that were over 80 characters.

Why two patches on one issue? Normally we just do one... I'll have to review these later, sorry, can't do it right now...

My mistake. The patches are identical and both include changes for both files. To keep it simple, please review the patch attached to this message.

Looks pretty good! I did notice this:

+ *   - view-mode-[view_mode]: The View Mode of the node; for example, "teaser"
+       or "full".

That second line is missing a * at the beginning.

Other than that, I think it looks fine. Thanks!

added the *

Thanks! Committed to 8.x. Needs reroll/port for 7.x

d7 patch

updated status

Thanks! I'll get this committed shortly.

Committed to 7.x. Thanks!