i have translated jRating into German and i was scared about the inconsistencies in this module.

Here are some things that should be merged and fixed:
1. "---", whatever this string should say me in different languages
2. sometimes you talk about "items", sometimes about "nodes" and so on
3. "type" should be named "content type". For e.g. "Yes: display a rating control with nodes of this type" should be "Yes, display a rating control with nodes of this content type."
4. sometimes the rating form is named "form", sometimes "control" and so on
5. The vote level names looks not very intuitive. Are this US voting names? School system in Germany have grades of "excellent", "good", "satisfactory", "fair", "poor", "unsatisfactory"... i currently don't know what "Great!", "Quite good" and "Not so great" should be in this grade!? Do you not like to get a "unsatisfactory" on a node? :-)
6. "Average rating" and "Average Rating" what should be named "Average rating", isn't it?
7. "Cancel Rating" cannot translated, aside this should be named "Cancel rating", isn't it?
8. Complete sentences should have an closing POINT.

Comments

hass’s picture

hass commented

#1: i found it, ok... should stay as is.
#3: should be "Yes, display a rating form with nodes of this content type."

hickory’s picture

hickory commented

2. It should be "nodes" for admins and "items" for end users. Is that the case?

3. What's the difference between "type" and "content type"?

4. Good point - I'll change them all to "widget".

5. You can put whatever you want for the voting strings - the defaults are the ones that I found most useful.

6+7: Yes, will fix those.

8: Not sure about this one; I don't think form element titles and result messages should end with a point.

hass’s picture

hass commented

#2. hm - maybe. i don't like have different strings here... In German a node is a "Beitrag" and the admin don't need to change their mind if he is switching from admin to frontend. This difference results in much confusion. please only use "node" as core does. i'd translated many projects and never seen a difference between admin and frontend.

#3. one major problem is the translation for translators. If i open the file in POEdit and read only "type" - i don't know what you are talking about. type of meet? type of drinks? :-) a "content" is the small word that helps all translators understanding what you are writing about AND the beginners understanding more and easier what you are writing about.

#5. this sounds difficult. please think about multilingual sites... default translation is english. therefor if i'd like to change the english strings i must alter your code. this is no good idea! i know i can change this strings in german, but the english strings are kept and therefor displayed. maybe it will be a good idea to have them customizable in general.

#8 well, labels not... i haven't looked directly in the code, but some strings looks like a sentense what looked more like a description from outside...

hass’s picture

hass commented

#3. nearly all modules i have translated have one or more "content type" strings anywhere... i never read type anywhere if "content type" was meant. Only as example in german i would translate "type" in "Typ" and "content type" will be "Inhaltstyp" - however you talk german or not - you see the big difference that makes 100% clear what we are talking about.

hickory’s picture

hickory commented

#3 - Ok, I'll change it to content type.

#5 - The locale module should be used to customise text strings.

hass’s picture

hass commented

#5. yes, but it's not possible to translate an english string to english, isn't it? so i'm forced to the strings jrating is using.

hickory’s picture

hickory commented

The way to do it is to set up a 'custom English' locale and set that as the default, then you can choose the text strings you want to change.

hickory’s picture

hickory commented
Status: Active » Fixed

These should all be fixed now, except the for node/item point, which has to stay that way so we can allow ratings for comments in the future (item covers both nodes and comments).

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)