Attached is a patch to add support for generating forum paths, so that menus don't disappear when visiting forum terms.

CommentFileSizeAuthor
forum.patch1.42 KBTripleEmcoder
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TripleEmcoder’s picture

TripleEmcoder CreditAttribution: TripleEmcoder commented
Status: Active » Needs review
Barrett’s picture

Barrett CreditAttribution: Barrett commented
Status: Needs review » Postponed (maintainer needs more info)

TripleEmcoder, can you clarify how to reproduce the issue this patch fixes?

TripleEmcoder’s picture

TripleEmcoder CreditAttribution: TripleEmcoder commented
Status: Postponed (maintainer needs more info) » Needs review

If you setup a taxonomy to generate menu items by default they get taxonomy/term/[tid] paths, which is fine for regular taxonomies, but not for forum taxonomies. If you navigate to a menu item like that, the forum module takes over and redirects form taxonomy/term/[tid] to forum/[tid], which in turn breaks the menu (it disappears), because Drupal sees different paths and does not consider the menu item as active.

My patch is basically a copy paste of the original path generating function, except it creates paths that will avoid these problems.

hles’s picture

hles CreditAttribution: hles commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Needs work

Needs to be rewritten for 7.x-2.x. Also the option should only be available only for installations that have the "forum" module activated.

funkytraffic’s picture

funkytraffic CreditAttribution: funkytraffic commented

For me the patch is working, but it should be working with Taxonomy Menu Trails.

hles’s picture

hles CreditAttribution: hles commented

If we had support for custom paths #1035446: Custom menu paths in D7, wouldn't it fix this issue ?

hles’s picture

hles CreditAttribution: hles commented
Status: Needs work » Postponed (maintainer needs more info)

To answer my own question, I think custom path sub-module solves this issue. Still, I'd like someone using forum paths to confirm that if possible.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I am using the Custom Path for the sole purpose of fixing this issue. Yes it does.

hles’s picture

hles CreditAttribution: hles commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

Ok then, let's close this.