We are using Google API v201107, which has been discontinued as of May 11th, 2012. This is a critical bug because it is currently affecting advertising income for the Association.

Level Of Effort

It will take approximately 0.5 days to fix this bug.

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Priority: Major » Critical

It was discontinued.

drumm’s picture

drumm
he/him
Location NY, US
commented

I recommend

  1. Remove google_dfp_api_replace_creative_view() since we are no longer using it for sponsor pages on association.drupal.org and I'm nt aware of anyone else using it. I don't see anything else to clean up other than removing just that.
  2. Review the API changes in Google's documentation and look for ways it may affect us. The only thing we do is connect and call google_dfp_api_populate_creative() to get sidebar ads for sponsors.
  3. Update the version number we use to as recent as possible and deploy.
jredding’s picture

jredding commented
Category: task » bug

@drumm Will this bug prevent sponsorship nodes from being created on a.d.o?

cosmicdreams’s picture

cosmicdreams commented

I'll look into this tonight. Integrating with Google's API is a passion of mine

drumm’s picture

drumm
he/him
Location NY, US
commented

Our staging server doesn't have PHP SOAP properly enabled, so #1601172: Better handle missing SOAP library would be nice to do.

cosmicdreams’s picture

cosmicdreams commented

would using http://code.google.com/p/google-api-php-client/ be appropriate.

drumm’s picture

drumm
he/him
Location NY, US
commented

We use http://code.google.com/p/google-api-dfp-php/, which requires PHP's native SOAP.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Fixed

This is fixed now
http://drupalcode.org/project/google_dfp_api.git/commit/034c089
http://drupalcode.org/project/google_dfp_api.git/commit/a17a7e8

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Adding a level of effort.