fboauth.api.php had its hook functions switched.

CommentFileSizeAuthor
fboauth-apidocs.patch750 bytesmrf

Comments

mrf’s picture

mrf commented
Status: Active » Needs review
quicksketch’s picture

quicksketch
he/him
commented

This patch doesn't make sense. Why would you put an @see hook_fboauth_user_save() in the PHPdoc of hook_fboauth_user_save()? The idea is that each hook tells the user to look at the other one. They're not supposed to reference themselves.

mrf’s picture

mrf commented

Ahhh ok that makes sense, I typically think of these example hook implementations as something to be copied and pasted, but you're right about it not making sense within the file itself if that change is made.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Closed (works as designed)

The primary purpose of the @see references is so that if FBOAuth is indexed by an API site (like api.drupal.org) links will automatically be generated to related functions. I see where you're coming from too, but that approach is not common in Drupal development.